This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add no-boolean-literal-compare rule
#2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchen63
suggested changes
Jan 10, 2017
| @@ -111,6 +111,10 @@ export class Replacement { | |||
| return replacements.reduce((text, r) => r.apply(text), content); | |||
| } | |||
|
|
|||
| public static deleteFromTo(start: number, end: number): Replacement { | |||
There was a problem hiding this comment.
can you use RuleWalker.deleteText(start: number, length: number) instead?
|
|
||
| function operatorKind(operatorToken: ts.BinaryOperatorToken): boolean | undefined { | ||
| switch (operatorToken.kind) { | ||
| case ts.SyntaxKind.EqualsEqualsToken: case ts.SyntaxKind.EqualsEqualsEqualsToken: |
| @@ -0,0 +1,30 @@ | |||
| declare const x: boolean; | |||
There was a problem hiding this comment.
add cases for more complex expressions like functions, result of binary boolean expression, and negating a boolean
|
how about a more explicit name to clarify that this only lints for literals? |
andy-hanson
changed the title
no-boolean-compare ruleno-boolean-literal-compare rule
nchen63
reviewed
Jan 11, 2017
| function needsParenthesesForNegate(node: ts.Expression) { | ||
| switch (node.kind) { | ||
| case ts.SyntaxKind.AsExpression: | ||
| case ts.SyntaxKind.BinaryExpression: |
There was a problem hiding this comment.
is there a more reliable way to check?
ternary?
There was a problem hiding this comment.
I can't think of a better way to do this, unfortunately.
A ternary operator wouldn't happen here since it === binds more tightly, so the ternary would have to be parenthesized already anyway.
nchen63
approved these changes
Jan 11, 2017
|
thanks, @andy-hanson |
|
Remember to close #1910 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
Added the
no-boolean-comparerule, which warns forx === true.