Update tslint:recommended configuration for 4.0 release

[adidahiya]

#Let's track the breaking changes we want to make to the tslint:recommended config here.

• TODO: list of changes
  • deprecate no-unused-variable Deprecate no-unused-variable rule #1618
  • remove no-duplicate-key Deprecate no-duplicate-key rule (covered by compiler)  #885
  • remove label-undefined Deprecate label-undefined rule (covered by compiler) #877
  • remove use-strict use-strict is (partially?) obsolete #678
  • remove no-unreachable deprecate no-unreachable once implemented in TS compiler #661
  • add no-unsafe-finally
  • add ordered-imports
    • compared to current tslint:latest, we want to change the named-imports-order option to "case-insensitive"
  • add new ones from Update tslint:latest configuration for 3.15 release #1506
  • add max-classes-per-file
  • add prefer-for-of
  • add array-type
  • add adjacent-overload-signatures
  • add object-literal-key-quotes
  • add object-literal-shorthand?
  • add only-arrow-functions/allow-declarations

---

Also, I was thinking it might be useful for users to have access to an older stable configuration so that they don't have to address all of 4.0's breaking changes at once. Perhaps a new config called tslint:3.x that is identical to the current tslint:latest?

[nchen63]

@adidahiya It looks like you changed no-unused-variable to deprecated already. I assume you didn't remove it since people need to turn on the compile flag

edit: I'll just change the list from remove to deprecated

[nchen63]

added some more from latest.ts:

add adjacent-overload-signatures
add object-literal-key-quotes
add object-literal-shorthand? <-- are you sure about this one?
add only-arrow-functions/allow-declarations

[adidahiya]

yep, I'm sure about object-literal-shorthand

[zhaytee]

Hey folks, trying out 4.0.0-dev.1 here. Very simple config and invocation:
tslint.json: { "extends": "tslint:recommended" }

invocation: $ node_modules/.bin/tslint -e "node_modules" "src/**/*.js"

I keep running into the following error:
Could not find implementations for the following rules specified in the configuration: no-duplicate-key

I grepped for that rule name, and it seems to be defined as part of the recommended set of rules. But the rule itself is no longer included with tslint, is that correct?

Edit: I edited the recommended ruleset file and changed no-duplicate-key to false, and now everything is working.

[nchen63]

@zhaytee it was removed with #1671, which didn't make it into 4.0.0-dev.1. Not sure why the rule appeared removed

[zhaytee]

@nchen63 Thanks for your reply. I rm -rf'd my node_modules dir and did a fresh yarn install, making sure that 4.0.0-dev.1 was being pulled down. Indeed, 4.0.0-dev.1 is the version installed, yet I'm still seeing the error message about no-duplicate-key not being found. See the attached screenshot for details.

Also, the error still goes away when I edit tslint/lib/configs/recommended.js and set no-duplicate-key to false. Not sure what's up. Happy to provide any more information if need be!

[nchen63]

@zhaytee You're right. I looked at the tag for dev.1, and it does reflect what you're seeing. Thanks for looking into this. dev.2 should be out soonish