Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react/prefer-stateless-function for tslint-react #117

Closed
dreadwail opened this issue Sep 17, 2017 · 7 comments
Closed

react/prefer-stateless-function for tslint-react #117

dreadwail opened this issue Sep 17, 2017 · 7 comments

Comments

@dreadwail
Copy link

Hello. When using ESlint with React I always enable the following rule:

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prefer-stateless-function.md

I was not able to find the same kind of rule for tslint-react.

  1. Is this something you feel would fit well into the project?
  2. If so, can I submit a pull-request to add the feature?

Thanks

@tomalexhughes
Copy link

Surprised to see that there's been no further discussion on this after 8 months.

I miss this a lot from ESLint and would love to see this for TypeScript.

@WillSquire
Copy link

Is this on the roadmap? With hooks and memo it seems to be a useful rule

@gangwarily
Copy link

The omission of this rule was one of the first thing I noticed between tslint-config-airbnb and eslint-config-airbnb. I'm still using eslint for the time being and applying it to my TypeScript file with typescript-eslint-parser.

@isaachinman
Copy link

@adidahiya What's the status on this? Is this free to pick up? Any advice on where to start?

@adidahiya
Copy link
Contributor

This is still open to PRs but it sounds like a tricky rule to implement correctly and keep in mind that it will be easy to use the ESLint version of this rule within the next few months (palantir/tslint#4534).

@isaachinman
Copy link

Yeah, saw those updates recently. Will leave this in favour of ESLint.

@adidahiya
Copy link
Contributor

Closing due to deprecation timeline #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants