Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit dependency on latest Gradle #687

Open
henryptung opened this issue Nov 19, 2019 · 1 comment
Open

Implicit dependency on latest Gradle #687

henryptung opened this issue Nov 19, 2019 · 1 comment

Comments

@henryptung
Copy link

What happened?

  1. Excavator updates Gradle wrapper version to latest.
  2. Plugin builds using gradleApi() dependency (both directly declared and implicitly declared via java-gradle-plugin)
  3. Plugin uses APIs that only exist in later Gradle (e.g. Provider.orElse(), since Gradle 5.6)
  4. Plugin fails in older Gradle 5.x projects (e.g. 5.2)

What did you want to happen?

Plugin should conform to version requirements as laid out in release notes (>= 5.1) and should not implicitly bump with every release.

Suggestions

  • Don't use Excavator to bump Gradle wrapper version
  • Replace gradleApi() dependency (and java-gradle-plugin) with an explicit dependency on a fixed version of Gradle API
@iamdanfox
Copy link
Contributor

(One more option is to run tests against the specific gradle version we intended to maintain compatibility with)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants