Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution tarballs contain bogus empty go-init and go-java-launcher directories #1139

Open
sfackler opened this issue May 17, 2021 · 0 comments

Comments

@sfackler
Copy link
Member

The last entries in a distribution tarball produced by the plugin look like this:

my-service-1.48.0-33-g0c0aacc/service/bin/go-init-1.11.0/
my-service-1.48.0-33-g0c0aacc/service/bin/go-init-1.11.0/service/
my-service-1.48.0-33-g0c0aacc/service/bin/go-init-1.11.0/service/bin/
my-service-1.48.0-33-g0c0aacc/service/bin/go-init-1.11.0/service/bin/darwin-amd64/
my-service-1.48.0-33-g0c0aacc/service/bin/go-init-1.11.0/service/bin/linux-amd64/
my-service-1.48.0-33-g0c0aacc/service/bin/go-init-1.11.0/service/bin/linux-arm64/
my-service-1.48.0-33-g0c0aacc/service/bin/go-java-launcher-1.11.0/
my-service-1.48.0-33-g0c0aacc/service/bin/go-java-launcher-1.11.0/service/
my-service-1.48.0-33-g0c0aacc/service/bin/go-java-launcher-1.11.0/service/bin/
my-service-1.48.0-33-g0c0aacc/service/bin/go-java-launcher-1.11.0/service/bin/darwin-amd64/
my-service-1.48.0-33-g0c0aacc/service/bin/go-java-launcher-1.11.0/service/bin/linux-amd64/
my-service-1.48.0-33-g0c0aacc/service/bin/go-java-launcher-1.11.0/service/bin/linux-arm64/

I believe this is because CopySpec#eachFile only runs on files and not directories, which prevents the rewrite logic here. An option to fix this is to disable includeEmptyDirs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant