[widgets] Add temporary messages for a fetch proxy #997
Conversation
styu
force-pushed
the
syu/fetch-proxy
branch
from
bea16cd
to
041064d
Compare
| * Temporary fetch proxy response | ||
| * Will be removed in favor of server side proxy | ||
| */ | ||
| export interface _unstable_FetchResponseSuccess { |
There was a problem hiding this comment.
i prefixed these with _unstable_ because i don't think they should be long lived
| M extends HostMessage<C>, | ||
| > { | ||
| (event: CustomEvent<M["payload"]>): void; | ||
| export interface HostMessageEventListener<P extends HostMessage.Payload> { |
There was a problem hiding this comment.
i learned these were all wrong and did not actually handle the union type correctly 🤦♀️
| } | ||
|
|
||
| function serializeHeaders(headers: HeadersInit | undefined) { | ||
| if (headers === undefined || !(headers instanceof Headers)) { |
There was a problem hiding this comment.
Apologies I know this is copied from me, but for completeness we could also error if not an instance of Headers, at least then all of the data type assumptions of this code error loudly if the client did something we don't support
There was a problem hiding this comment.
So HeadersInit can be any of the following string, string][] | Record<string, string> | Headers. But also you can pass all of those to new Headers() to ensure you have a headers object.
You could also therefore simplify serialization to just [...new Headers(headers ?? {}).entries()] and rehydrate on the other side with new Headers(...)
| return new Promise<Response>((resolve, reject: (error: Error) => void) => { | ||
| function handleMessage(event: MessageEvent) { | ||
| const { data } = event; | ||
| visitHostMessage(event.data, { |
There was a problem hiding this comment.
lol i like that the compiler complains if you leave something out!
| } | ||
|
|
||
| function serializeHeaders(headers: HeadersInit | undefined) { | ||
| if (headers === undefined || !(headers instanceof Headers)) { |
There was a problem hiding this comment.
So HeadersInit can be any of the following string, string][] | Record<string, string> | Headers. But also you can pass all of those to new Headers() to ensure you have a headers object.
You could also therefore simplify serialization to just [...new Headers(headers ?? {}).entries()] and rehydrate on the other side with new Headers(...)
policy-bot
bot
dismissed
rosscourt’s stale review
Invalidated by push of b260312
| @@ -32,22 +32,13 @@ export function serializeRequest( | |||
| id, | |||
| url: input, | |||
| method: init?.method ?? "GET", | |||
| headers: serializeHeaders(init?.headers), | |||
| headers: Object.fromEntries([ | |||
There was a problem hiding this comment.
super nit: you dont need to fromEntries here since [string, string][] is a valid HeadersInit which will work on the other side
policy-bot
bot
dismissed
ericanderson’s stale review
Invalidated by push of 482bc68
This does expose the OSDK create client function on the widget client, which is nice because we deal with figuring out the URL for them when within the sandbox.
The end goal is to not have to proxy on the frontend and instead create a proxy on the server so we don't have to endlessly mirror all fetch/browser functionality, but we need this for now to show it working end to end first