Interfaces for Subscribe #1018
Interfaces for Subscribe #1018
Conversation
| @@ -432,15 +452,17 @@ export class ObjectSetListenerWebsocket { | |||
| ); | |||
| const osdkObjectsWithReferenceUpdates = await Promise.all( | |||
| referenceUpdates.map(async (o) => { | |||
| const osdkObjectArray = await convertWireToOsdkObjects( | |||
| const osdkObjectArray = await this.#client.objectFactory( | |||
There was a problem hiding this comment.
I'm using the old interface API's since the our new implementations require an interface to object type properties map. I could manually create this, but I think it would be best to talk through this @ssanjay1 and just unblock for right now
| objDef.properties[p].type === "geotimeSeriesReference" | ||
| ); | ||
| } else { | ||
| objectProperties = []; |
There was a problem hiding this comment.
OSW assumes the names we provide them are the API names for the actual object type implementations instead of the SPT names. Therefore the current API I decided on was assuming if you pass an interface in that you are only specifying reference properties. This does require any casting what is passed in, and I think it's a larger conversation if the TS OSDK supports specifying anything beyond an SPT.
There was a problem hiding this comment.
There are ongoing discussions to allow OSW to take in the SPT names instead of the object type property API names here. I'll also open up the discussion as to how we want to allow requesting reference properties in the finalized API
Allows for interfaces on object set subscriptions