Adds @osdk/react #1008
Adds @osdk/react #1008
Conversation
ericanderson
force-pushed
the
ea.osdk-react
branch
2 times, most recently
from
d69f844
to
481b0e3
Compare
ericanderson
force-pushed
the
ea.osdk-react
branch
from
7a53100
to
e3eb40d
Compare
| function Home() { | ||
|
|
||
| // const client = useOsdkClient(); |
There was a problem hiding this comment.
Assuming you left this in case people want to use it in the template, but just double checking is this intended?
There was a problem hiding this comment.
Correct. This lets me generate an example usage for people while still making compilable code. Ideally I could do this by detecting an object but I think thats a much bigger project and this scratches the need.
| ) | ||
| .replace( | ||
| // Use locally generated SDK in the monorepo | ||
| /"@osdk\/react": "[\^~].*?"/, |
There was a problem hiding this comment.
Like everything else unchanged?
There was a problem hiding this comment.
Correct, everything else is just indentation/alignment so that introducing a new one is just new lines. PS you can tell GH to ignore whitespace changes
|
|
||
| export function useCombinedPages<T extends ObjectOrInterfaceDefinition>( | ||
| data: PageResult<Osdk.Instance<T, never, any>>[] | undefined, | ||
| ): Osdk.Instance<T>[] { |
There was a problem hiding this comment.
Should the return type not include the property keys if they sub-selected in their fetchPage?
There was a problem hiding this comment.
Oops, yes I think so. I also don't think I am ready to ship that function. I forget I had that in there.
No description provided.