Updates gateway versions and uses Response type for Binary Data (#1013)

* Update to use response type * changest
palantir · Nov 22, 2024 · 6b6c8a1 · 6b6c8a1
1 parent 0a7c747
commit 6b6c8a1
Show file tree

Hide file tree

Showing 18 changed files with 116 additions and 108 deletions.
diff --git a/.changeset/tasty-rats-sparkle.md b/.changeset/tasty-rats-sparkle.md
@@ -0,0 +1,12 @@
+---
+"@osdk/foundry-sdk-generator": patch
+"@osdk/generator-converters": patch
+"@osdk/cli.cmd.typescript": patch
+"@osdk/shared.test": patch
+"@osdk/generator": patch
+"@osdk/client": patch
+"@osdk/maker": patch
+"@osdk/api": patch
+---
+
+Updates gateway endpoints and changes fetchContents for attachments to return a response
diff --git a/.gitignore b/.gitignore
@@ -36,4 +36,6 @@ pnpm-publish-summary.json
 
 api-docs/
 temp/
-tsup.config.bundled_*.mjs
+tsup.config.bundled_*.mjs
+
+vitest.workspace.ts
diff --git a/etc/api.report.api.md b/etc/api.report.api.md
@@ -197,7 +197,7 @@ export interface AsyncIterArgs<Q extends ObjectOrInterfaceDefinition, K extends
 
 // @public (undocumented)
 export interface Attachment {
-    fetchContents(): Promise<Blob>;
+    fetchContents(): Promise<Response>;
     // Warning: (ae-forgotten-export) The symbol "AttachmentMetadata" needs to be exported by the entry point index.d.ts
     fetchMetadata(): Promise<AttachmentMetadata>;
     // (undocumented)

diff --git a/packages/api/src/object/Attachment.ts b/packages/api/src/object/Attachment.ts
@@ -23,7 +23,7 @@ export interface Attachment {
   /**
    * Fetches actual content of attachment in Blob form
    */
-  fetchContents(): Promise<Blob>;
+  fetchContents(): Promise<Response>;
 }
 /**
  * This interface should also accept the File object from

diff --git a/packages/cli.cmd.typescript/package.json b/packages/cli.cmd.typescript/package.json
@@ -32,8 +32,8 @@
     "@arethetypeswrong/cli": "^0.15.2",
     "@osdk/cli.common": "workspace:~",
     "@osdk/generator": "workspace:~",
-    "@osdk/internal.foundry.core": "2.6.0-beta.0",
-    "@osdk/internal.foundry.ontologiesv2": "2.6.0-beta.0",
+    "@osdk/internal.foundry.core": "2.6.0-beta.1",
+    "@osdk/internal.foundry.ontologiesv2": "2.6.0-beta.1",
     "@osdk/shared.net": "workspace:~",
     "consola": "^3.2.3",
     "fast-deep-equal": "^3.1.3",

diff --git a/packages/client/package.json b/packages/client/package.json
@@ -35,8 +35,8 @@
     "@osdk/api": "workspace:~",
     "@osdk/client.unstable": "workspace:*",
     "@osdk/generator-converters": "workspace:*",
-    "@osdk/internal.foundry.core": "2.6.0-beta.0",
-    "@osdk/internal.foundry.ontologiesv2": "2.6.0-beta.0",
+    "@osdk/internal.foundry.core": "2.6.0-beta.1",
+    "@osdk/internal.foundry.ontologiesv2": "2.6.0-beta.1",
     "@osdk/shared.client": "^1.0.1",
     "@osdk/shared.client.impl": "workspace:~",
     "@osdk/shared.client2": "^1.0.0",

diff --git a/packages/client/src/createAttachmentFromRid.ts b/packages/client/src/createAttachmentFromRid.ts
@@ -34,7 +34,7 @@ export function createAttachmentFromRid(
       return OntologiesV2.Attachments.read(
         client,
         rid,
-      ) as Promise<Blob>;
+      );
     },
     async fetchMetadata() {
       const r = await OntologiesV2.Attachments.get(client, rid);

diff --git a/packages/client/src/util/timeseriesUtils.ts b/packages/client/src/util/timeseriesUtils.ts
@@ -17,6 +17,7 @@
 import type { TimeSeriesQuery } from "@osdk/api";
 import { TimeseriesDurationMapping, TimeSeriesPoint } from "@osdk/api";
 import type { TimeRange } from "@osdk/internal.foundry.core";
+import invariant from "tiny-invariant";
 import { iterateReadableStream, parseStreamedResponse } from "./streamutils.js";
 
 export function getTimeRange(body: TimeSeriesQuery): TimeRange {
@@ -49,9 +50,9 @@ export function getTimeRange(body: TimeSeriesQuery): TimeRange {
 export async function* asyncIterPointsHelper<
   T extends number | string | GeoJSON.Point,
 >(
-  iterator: Blob,
+  iterator: Response,
 ) {
-  const reader = iterator.stream().getReader();
+  const reader = iterator.body?.getReader()!;
   for await (
     const point of parseStreamedResponse(iterateReadableStream(reader))
   ) {

diff --git a/packages/foundry-sdk-generator/package.json b/packages/foundry-sdk-generator/package.json
@@ -33,12 +33,12 @@
   "dependencies": {
     "@osdk/api": "workspace:*",
     "@osdk/client": "workspace:*",
-    "@osdk/foundry.core": "2.6.0-beta.0",
-    "@osdk/foundry.thirdpartyapplications": "2.6.0-beta.0",
+    "@osdk/foundry.core": "2.6.0-beta.1",
+    "@osdk/foundry.thirdpartyapplications": "2.6.0-beta.1",
     "@osdk/generator": "workspace:*",
-    "@osdk/internal.foundry.core": "2.6.0-beta.0",
-    "@osdk/internal.foundry.ontologies": "2.6.0-beta.0",
-    "@osdk/internal.foundry.ontologiesv2": "2.6.0-beta.0",
+    "@osdk/internal.foundry.core": "2.6.0-beta.1",
+    "@osdk/internal.foundry.ontologies": "2.6.0-beta.1",
+    "@osdk/internal.foundry.ontologiesv2": "2.6.0-beta.1",
     "@osdk/shared.net": "workspace:*",
     "@rollup/plugin-commonjs": "28.0.0",
     "@rollup/plugin-node-resolve": "15.3.0",

diff --git a/packages/generator-converters/package.json b/packages/generator-converters/package.json
@@ -32,7 +32,7 @@
   },
   "dependencies": {
     "@osdk/api": "workspace:~",
-    "@osdk/internal.foundry.core": "2.6.0-beta.0"
+    "@osdk/internal.foundry.core": "2.6.0-beta.1"
   },
   "devDependencies": {
     "@osdk/monorepo.api-extractor": "workspace:~",

diff --git a/packages/generator-converters/src/getEditedEntities.ts b/packages/generator-converters/src/getEditedEntities.ts
@@ -39,6 +39,7 @@ export function getModifiedEntityTypes(
       case "deleteLink":
       case "createInterfaceObject":
       case "modifyInterfaceObject":
+      case "deleteInterfaceObject":
         break;
       default:
         const _: never = operation;

diff --git a/packages/generator-converters/src/wireActionTypeV2ToSdkActionMetadata.ts b/packages/generator-converters/src/wireActionTypeV2ToSdkActionMetadata.ts
@@ -79,6 +79,8 @@ function actionPropertyToSdkPropertyDefinition(
       return { type: "object", object: parameterType.objectTypeApiName };
     case "array":
       return actionPropertyToSdkPropertyDefinition(parameterType.subType);
+    default:
+      throw new Error(`Unsupported action parameter type: ${parameterType}`);
   }
 }
 

diff --git a/packages/generator/package.json b/packages/generator/package.json
@@ -33,7 +33,7 @@
   "dependencies": {
     "@osdk/api": "workspace:~",
     "@osdk/generator-converters": "workspace:~",
-    "@osdk/internal.foundry.core": "2.6.0-beta.0",
+    "@osdk/internal.foundry.core": "2.6.0-beta.1",
     "fast-deep-equal": "^3.1.3",
     "fetch-retry": "^6.0.0",
     "prettier": "^3.0.3",

diff --git a/packages/maker/package.json b/packages/maker/package.json
@@ -37,7 +37,7 @@
   },
   "devDependencies": {
     "@osdk/client.unstable": "workspace:~",
-    "@osdk/internal.foundry.core": "2.6.0-beta.0",
+    "@osdk/internal.foundry.core": "2.6.0-beta.1",
     "@osdk/monorepo.api-extractor": "workspace:~",
     "@osdk/monorepo.tsconfig": "workspace:~",
     "@osdk/monorepo.tsup": "workspace:~",

diff --git a/packages/shared.test/package.json b/packages/shared.test/package.json
@@ -31,10 +31,10 @@
   },
   "dependencies": {
     "@osdk/api": "workspace:~",
-    "@osdk/internal.foundry.core": "2.6.0-beta.0",
-    "@osdk/internal.foundry.geo": "2.6.0-beta.0",
-    "@osdk/internal.foundry.ontologies": "2.6.0-beta.0",
-    "@osdk/internal.foundry.ontologiesv2": "2.6.0-beta.0",
+    "@osdk/internal.foundry.core": "2.6.0-beta.1",
+    "@osdk/internal.foundry.geo": "2.6.0-beta.1",
+    "@osdk/internal.foundry.ontologies": "2.6.0-beta.1",
+    "@osdk/internal.foundry.ontologiesv2": "2.6.0-beta.1",
     "fetch-retry": "^6.0.0",
     "json-stable-stringify": "^1.1.1",
     "msw": "^2.3.4",

diff --git a/packages/shared.test/src/handlers/loadObjectsEndpoints.ts b/packages/shared.test/src/handlers/loadObjectsEndpoints.ts
@@ -599,11 +599,7 @@ export const loadObjectsEndpoints: Array<RequestHandler> = [
         attachmentContentRequest[attachmentRid];
 
       if (getAttachmentContentResponse) {
-        const blob = new Blob(
-          [JSON.stringify(getAttachmentContentResponse)],
-          { type: "application/json" },
-        );
-        return blob;
+        return new Response(JSON.stringify(getAttachmentContentResponse));
       }
 
       throw new OpenApiCallError(404, AttachmentNotFoundError);
@@ -639,11 +635,7 @@ export const loadObjectsEndpoints: Array<RequestHandler> = [
       const getAttachmentContentResponse =
         attachmentContentRequest[propertyName];
       if (getAttachmentContentResponse) {
-        const blob = new Blob(
-          [JSON.stringify(getAttachmentContentResponse)],
-          { type: "application/json" },
-        );
-        return blob;
+        return new Response(JSON.stringify(getAttachmentContentResponse));
       }
 
       throw new OpenApiCallError(404, AttachmentNotFoundError);
@@ -705,11 +697,7 @@ async function handleStreamValues(
       || req.params.ontologyApiName === defaultOntology.rid)
     && req.params.objectType === employeeObjectType.apiName
   ) {
-    const blob = new Blob(
-      [JSON.stringify(streamPointsResp)],
-      { type: "application/json" },
-    );
-    return blob;
+    return new Response(JSON.stringify(streamPointsResp));
   }
   throw new OpenApiCallError(400, InvalidRequest("Invalid request"));
 }
diff --git a/packages/shared.test/src/handlers/util/handleOpenApiCall.ts b/packages/shared.test/src/handlers/util/handleOpenApiCall.ts
@@ -128,8 +128,10 @@ export function handleOpenApiCall<
             info as any,
           );
 
-          if (result instanceof Blob) {
-            return new HttpResponse(result) as StrictResponse<DefaultBodyType>;
+          if (result instanceof Response) {
+            return new HttpResponse(result.body) as StrictResponse<
+              DefaultBodyType
+            >;
           }
           return HttpResponse.json(
             result,