Generated typescript incorrect if endpoint path args ordering doesn't match the order they appear in the path

[bavardage]

What happened?

Generated code assumes the ordering of path params in the endpoint args block matches the ordering of those params in the path.

i.e. if you have

http: POST /{one}/{two}/{three}
args:
    two: string
    three: string
    one: string

the generated code will incorrectly substitute to create the path {two}/{three}/{one}

What did you want to happen?

The substitution should be based on the names of the params, not the ordering.

[bavardage]

conjure-typescript/src/commands/generate/serviceGenerator.ts

Lines 156 to 166 in b39e8f4

	endpointDefinition.args.forEach(argDefinition => {
	if (IParameterType.isBody(argDefinition.paramType)) {
	bodyArgs.push(argDefinition);
	} else if (IParameterType.isPath(argDefinition.paramType)) {
	pathArgNames.push(argDefinition.argName);
	} else if (IParameterType.isHeader(argDefinition.paramType)) {
	headerArgs.push(argDefinition);
	} else if (IParameterType.isQuery(argDefinition.paramType)) {
	queryArgs.push(argDefinition);
	}
	});

is where the path params are pulled out

then in

conjure-typescript/src/commands/generate/serviceGenerator.ts

Line 203 in b39e8f4

writer.write("pathArguments: [");

they're passed only by position

they're then used in https://github.com/palantir/conjure-typescript-runtime/blob/develop/packages/conjure-client/src/fetchBridge/fetchBridge.ts#L165