Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servers cannot deserialize empty primitive optional values sent by Feign clients #1331

Open
pkoenig10 opened this issue Nov 20, 2019 · 1 comment

Comments

@pkoenig10
Copy link
Member

What happened?

A service is exposing an endpoint with an OptionalLong header parameter. A Conjure Feign client calls this endpoint with an OptionalLong.empty() value and receives a 400 because this parameter fails to deserialize with NumberFormatException.

What did you want to happen?

The request from the client should have succeeded.

Details

This is related to #790.

Requests with Optional<T> parameters work because Jersey will return null if an exception is thrown while deserializing an empty string.

@carterkozak
Copy link
Contributor

The conjure spec requires optional headers to be absent from the request to deserialize into an empty optional, otherwise we would not be able to differentiate between a present optional of an empty string, and and absent optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants