Add type attribute to tag remove button #551
Conversation
|
Thanks for your interest in palantir/blueprint, @devjunkORG! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
vcanales
force-pushed
the
dj/issue-550
branch
from
9196eb1 to
fdf315f
Compare
| @@ -35,7 +35,8 @@ export class Tag extends React.Component<ITagProps, {}> { | |||
| return ( | |||
| <span {...removeNonHTMLProps(this.props)} className={tagClasses}> | |||
| {this.props.children} | |||
| {isFunction(onRemove) ? <button className={Classes.TAG_REMOVE} onClick={onRemove} /> : null} | |||
| {isFunction(onRemove) ? <button type="button" className={Classes.TAG_REMOVE} onClick={onRemove} /> | |||
| : null} | |||
There was a problem hiding this comment.
pull this out to a local variable or bring back to one line.
There was a problem hiding this comment.
I was doing just that. Also, I'm sorry, I added PR metadata to the commit message before I should have.
vcanales
force-pushed
the
dj/issue-550
branch
from
c547bd3 to
256dd98
Compare
comply with linting rules PR: palantir#551 refactor button, move to variable
vcanales
force-pushed
the
dj/issue-550
branch
from
256dd98 to
b5e4a6c
Compare
|
|
||
| return ( | ||
| <span {...removeNonHTMLProps(this.props)} className={tagClasses}> | ||
| {this.props.children} | ||
| {isFunction(onRemove) ? <button className={Classes.TAG_REMOVE} onClick={onRemove} /> : null} | ||
| {isFunction(onRemove) ? button : null} |
There was a problem hiding this comment.
i meant pull the whole statement out. no need to create the object when the function is false. this should say just {button}
also please use undefined instead of null.
vcanales
force-pushed
the
dj/issue-550
branch
from
b5e4a6c to
b61ea90
Compare
will keep that in mind, thanks! |
Fixes #550
Checklist
Changes proposed in this pull request:
Add
typeattribute to remove buttons on Tag components, since not having type="button" submits forms that contain the element on some browsers.