[POC] Fix popover issues on docs page in Firefox and Chrome #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on fixed/absolute
cmslewis
changed the title
cmslewis
commented
Dec 1, 2016
| @@ -284,7 +307,7 @@ export class Overlay extends React.Component<IOverlayProps, IOverlayState> { | |||
| if (autofocusElement != null) { | |||
| autofocusElement.focus(); | |||
| } else { | |||
| containerElement.focus(); | |||
| setTimeout(containerElement.focus); | |||
There was a problem hiding this comment.
This line is the only real change in this PR.
cmslewis
changed the title
|
Closing in favor of #326. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[⚠️ This is just a proof-of-concept. Don't merge in its current state. ]
Fixes #231
Changes proposed in this pull request:
setTimeoutaround the call to focus on the popover container element after it renders (we're currently focusing before the container is visible, so the browser is simply scrolling down tot the invisible.pt-portalat the bottom of the page).Reviewers should focus on:
masterwill reveal the true changes here, so let's do that before merging this one.