Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blueprintPortalClassName supports multiple classes #2255

Merged
merged 2 commits into from
Mar 16, 2018
Merged

blueprintPortalClassName supports multiple classes #2255

merged 2 commits into from
Mar 16, 2018

Conversation

giladgray
Copy link
Contributor

Fixes #2253

@giladgray giladgray requested a review from adidahiya March 16, 2018 00:14
@blueprint-bot
Copy link

blueprintPortalClassName supports multiple classes

Preview: documentation | landing | table

adidahiya
adidahiya approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rad ✌️

@adidahiya adidahiya merged commit 2ebe7ba into develop Mar 16, 2018
@adidahiya adidahiya deleted the gg/portal-class branch March 16, 2018 04:05
@adidahiya
Copy link
Contributor

needs to be ported to 1.x though

@adidahiya
Copy link
Contributor

#2257

adidahiya added a commit that referenced this pull request Mar 16, 2018
@adidahiya
[release/1.x] Port #2255 to support multiple classes in blueprintPort…
a8703a4 
…alClassName (#2257)
This was referenced Mar 21, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @adidahiya