[2.0] docs site redesign! #2243

giladgray · 2018-03-15T01:52:17Z

woooooo new design!

To do:

…site-2.0

refactor NavMenu & NavMenuItem accordingly

…site-2.0

flex layout with contrasting background on sidebar, cool nav buttons, lots of padding cleanup

blueprint-bot · 2018-03-15T01:54:10Z

prevent body scrolling

Preview: documentation | landing | table

adidahiya

looks pretty sweet overall! couple notes:

can I get ESC to close this omnibar please?

also can it inherit dark theme?

lastly, these keyboard shortcuts feel out of place, kind of in your face... I would prefer them labeled in a tooltip:

adidahiya · 2018-03-15T17:00:39Z

packages/docs-theme/src/styles/_layout.scss

+    &.docs-nav-expanded {
+      // bold text instead of background color
+      background-color: transparent !important; // stylelint-disable-line declaration-no-important
+      font-weight: 600;


unfortunate side effect of this is that it can change the number of lines which an item takes up. so it can push down the layout of the rest of the nav tree. a minor inconvenience 🤷‍♂️

yeah I noticed as well, I'll update that but maybe not in this PR (unless I figure something great before this merges)

llorca · 2018-03-15T17:45:37Z

@adidahiya re: shortcuts, they're actually disabled text, can hardly go less in your face than that. we want to display them for a while to let people get used to it, and we can probably remove them at some point.
re: esc to close the omnibar, it already works on my end. did you catch a bug?

blueprint-bot · 2018-03-20T03:31:35Z

🌟 Components becomes non-interactive header that expands its menu!

Preview: documentation | landing | table

qcz · 2018-03-20T09:00:23Z

@giladgray: When using the latest preview by blueprint-bot, the left menu can't be scrolled in Firefox and Edge.

inject some styles to add padding equal to scrollbar width when Overlay open

giladgray · 2018-03-20T21:30:02Z

@qcz i believe i've resolved the scrolling issues. thanks for reporting!

blueprint-bot · 2018-03-20T21:34:48Z

restore scroll spy

Preview: documentation | landing | table

blueprint-bot · 2018-03-20T22:27:43Z

new Logo component rendering logo SVG inline

Preview: documentation | landing | table

giladgray

@llorca I reviewed your commit

giladgray · 2018-03-20T22:35:23Z

packages/docs-app/src/components/logo.tsx

@@ -0,0 +1,27 @@
+/*
+ * Copyright 2015 Palantir Technologies, Inc. All rights reserved.


giladgray · 2018-03-20T22:35:35Z

packages/docs-app/src/components/logo.tsx

+export const Logo: React.SFC<ILogoProps> = ({ color }) => {
+    return (
+        <svg width="65" height="76" xmlns="http://www.w3.org/2000/svg">
+            <g fill={color} fill-rule="nonzero">


giladgray · 2018-03-20T22:37:50Z

packages/docs-app/src/styles/_nav.scss

@@ -32,20 +32,35 @@ $dark-package-colors: (

 .docs-logo {
  display: block;
+  opacity: 0.8;
  margin-right: $logo-margin;
  background-image: url("./assets/blueprint-logo.svg");


remove these background properties, and the associated file.

while you're at it, refactor this entire class. i'll bet half the properties aren't necessary anymore.

…site-2.0

close navigator when an item is selected, in case it's the current section

blueprint-bot · 2018-03-21T00:16:57Z

fix sidebar width, remove left padding

Preview: documentation | landing | table

llorca · 2018-03-21T04:10:40Z

can we remove the banner now since next time we ship the docs it'll be the stable release?
this is looking and working pretty good 😍 shall we merge or do you expect more code review?

make sure the interface description doesn't shrink in api overlay

blueprint-bot · 2018-03-21T04:27:26Z

fix api overlay desc size

Preview: documentation | landing | table

giladgray · 2018-03-21T17:10:58Z

@llorca let's merge now and remove banner later. approval?

blueprint-bot · 2018-03-21T18:33:41Z

make copy to clipboard tick consistent everywhere

Preview: documentation | landing | table

giladgray · 2018-03-21T18:42:40Z

packages/docs-app/src/styles/_colors.scss

@@ -40,6 +40,7 @@ $swatch-copied-message: "#{$pt-icon-tick} Copied to clipboard";
  // override more specific selector above
  //stylelint-disable declaration-no-important
  &.docs-clipboard-copied .docs-clipboard-message::after {
+    font-family: $pt-font-family;


but we want monospace. whatever.

Antoine Llorca and others added 24 commits December 15, 2017 12:08

new docs design

9241c56

Merge remote-tracking branch 'origin/master' into feature/site-2.0

af2a0ff

add icons for icons and select

474c7a4

Merge branch 'develop' of github.com:palantir/blueprint into feature/…

66be859

…site-2.0

move Banner into docs-theme

f8000fe

fix logo/title alignment

ebec595

NavbarActions uses ButtonGroup

4a28124

replace navbarLeft/Right props with one title prop

915cce3

nav styles

717d7c8

refactor Navigator to use Omnibar, separate NavigatorTrigger SFC

ae5c716

add select dependency

042cc3e

Merge branch 'develop' of github.com:palantir/blueprint into feature/…

1d73b25

…site-2.0

add renderNavMenuItem prop to Documentation

b9de85b

refactor NavMenu & NavMenuItem accordingly

refactor NavMenu styles and pull NavMenuItem to separate file

2aa72bf

custom nav menu items in BlueprintDocs

2dbf749

rename JS table page

c43222c

Merge branch 'develop' of github.com:palantir/blueprint into feature/…

f19ee92

…site-2.0

update timezone icon, mute pkg version link

2891d91

big refactors to docs-theme

b11938c

flex layout with contrasting background on sidebar, cool nav buttons, lots of padding cleanup

NavbarActions => NavHeader, new style

2ccd94a

tweak spacing variables

efe5b0a

improve pkg icon colors

844a935

navigator styles

2480e1c

prevent body scrolling

d1b7664

giladgray requested review from llorca and adidahiya March 15, 2018 01:52

adidahiya reviewed Mar 15, 2018

View reviewed changes

prevent nav wrapper from scrolling horizontally

334758f

Gilad Gray added 3 commits March 20, 2018 14:27

switch back to body scroll container layout

cadae7a

prevent page shift when Overlay open:

b25ed4e

inject some styles to add padding equal to scrollbar width when Overlay open

restore scroll spy

433c7ba

new Logo component rendering logo SVG inline

ed541fc

giladgray commented Mar 20, 2018

View reviewed changes

giladgray mentioned this pull request Mar 20, 2018

[docs] fix color aliases table #2286

Merged

Gilad Gray added 5 commits March 20, 2018 16:48

Merge branch 'develop' of github.com:palantir/blueprint into feature/…

18b4e60

…site-2.0

refactor logo styles, delete old SVG files

6088a31

small navigator style fixes

0188e90

close navigator when an item is selected, in case it's the current section

fix docs-nav height with banner

0442895

fix sidebar width, remove left padding

bd004a5

fix api overlay desc size

7207678

make sure the interface description doesn't shrink in api overlay

giladgray mentioned this pull request Mar 21, 2018

[Popover] Popover sometimes detaches from navbar in docs #845

Closed

llorca approved these changes Mar 21, 2018

View reviewed changes

make copy to clipboard tick consistent everywhere

c76b37a

giladgray commented Mar 21, 2018

View reviewed changes

giladgray merged commit aa7c736 into develop Mar 21, 2018

giladgray deleted the feature/site-2.0 branch March 21, 2018 18:43

This was referenced Mar 21, 2018

🌟 Prepare Release v2.0.0 🌟 #2290

Closed

Prepare Release v2.0.0-rc.4 #2291

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[2.0] docs site redesign! #2243

[2.0] docs site redesign! #2243

giladgray commented Mar 15, 2018 •

edited

Loading

blueprint-bot commented Mar 15, 2018

adidahiya left a comment

adidahiya Mar 15, 2018

llorca Mar 15, 2018

llorca commented Mar 15, 2018

blueprint-bot commented Mar 20, 2018 •

edited by giladgray

Loading

qcz commented Mar 20, 2018

giladgray commented Mar 20, 2018

blueprint-bot commented Mar 20, 2018

blueprint-bot commented Mar 20, 2018

giladgray left a comment

giladgray Mar 20, 2018

giladgray Mar 20, 2018

giladgray Mar 20, 2018

blueprint-bot commented Mar 21, 2018

llorca commented Mar 21, 2018

blueprint-bot commented Mar 21, 2018

giladgray commented Mar 21, 2018

blueprint-bot commented Mar 21, 2018

giladgray Mar 21, 2018

		@@ -0,0 +1,27 @@
		/*
		* Copyright 2015 Palantir Technologies, Inc. All rights reserved.

[2.0] docs site redesign! #2243

[2.0] docs site redesign! #2243

Conversation

giladgray commented Mar 15, 2018 • edited Loading

blueprint-bot commented Mar 15, 2018

prevent body scrolling

adidahiya left a comment

Choose a reason for hiding this comment

adidahiya Mar 15, 2018

Choose a reason for hiding this comment

llorca Mar 15, 2018

Choose a reason for hiding this comment

llorca commented Mar 15, 2018

blueprint-bot commented Mar 20, 2018 • edited by giladgray Loading

🌟 Components becomes non-interactive header that expands its menu!

qcz commented Mar 20, 2018

giladgray commented Mar 20, 2018

blueprint-bot commented Mar 20, 2018

restore scroll spy

blueprint-bot commented Mar 20, 2018

new Logo component rendering logo SVG inline

giladgray left a comment

Choose a reason for hiding this comment

giladgray Mar 20, 2018

Choose a reason for hiding this comment

giladgray Mar 20, 2018

Choose a reason for hiding this comment

giladgray Mar 20, 2018

Choose a reason for hiding this comment

blueprint-bot commented Mar 21, 2018

fix sidebar width, remove left padding

llorca commented Mar 21, 2018

blueprint-bot commented Mar 21, 2018

fix api overlay desc size

giladgray commented Mar 21, 2018

blueprint-bot commented Mar 21, 2018

make copy to clipboard tick consistent everywhere

giladgray Mar 21, 2018

Choose a reason for hiding this comment

giladgray commented Mar 15, 2018 •

edited

Loading

blueprint-bot commented Mar 20, 2018 •

edited by giladgray

Loading