Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tag] use Icon in remove button #2231

Merged
merged 2 commits into from
Mar 14, 2018
Merged

[tag] use Icon in remove button #2231

merged 2 commits into from
Mar 14, 2018

Conversation

giladgray
Copy link
Contributor

Fixes #2225

  • Tag remove button renders Icon (and preserves CSS support)
  • add options to TagExample and move to top of docs page

tag-example-options

@giladgray giladgray requested a review from llorca March 13, 2018 21:06
@giladgray giladgray mentioned this pull request Mar 13, 2018
Closed
@giladgray giladgray requested a review from adidahiya March 13, 2018 21:10
@blueprint-bot
Copy link

add options to TagExample, move to top of docs

Preview: documentation | landing | table

@adidahiya adidahiya merged commit 74e7c1a into develop Mar 14, 2018
@adidahiya adidahiya deleted the gg/tag-remove-icon branch March 14, 2018 00:14
This was referenced Mar 21, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

@llorca llorca llorca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giladgray @blueprint-bot @llorca @adidahiya