Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issues before change:
color
is not handled in<Icon>
because:blueprint/packages/core/src/components/icon/icon.tsx
Lines 19 to 24 in 6cc104e
blueprint/packages/core/src/components/icon/icon.tsx
Lines 64 to 68 in 6cc104e
Changes proposed in this pull request:
This PR fixed a issue that
color
property doesn't work on<Icon>
:Reviewers should focus on:
If user also pass a
style
to the component, finalstyle
should includes user defined properties:Screenshot