Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix querylist classname regression #2212

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Fix querylist classname regression #2212

merged 1 commit into from
Mar 7, 2018

Conversation

k-simons
Copy link
Contributor

@k-simons k-simons commented Mar 7, 2018 •
edited
Loading

Fixes #0000

Checklist

Changes proposed in this pull request:

  • There is a regression in 2.x where the classname passed to a Select, which is then passed into a QueryList is not passed back to the Select.renderer to be attached on the popover
  • Accidentally closed Fix querylist classname regression #2211

Reviewers should focus on:

Screenshot

@k-simons k-simons mentioned this pull request Mar 7, 2018
Closed
3 tasks
@giladgray giladgray merged commit 7ef988a into palantir:develop Mar 7, 2018
@k-simons k-simons deleted the ksimons/fixSelectClassnameRegression branch March 7, 2018 19:19
@giladgray giladgray mentioned this pull request Mar 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladgray giladgray giladgray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-simons @giladgray