fix ofType syntax #2209
Merged
fix ofType syntax #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladgray
commented
Mar 7, 2018
| @@ -63,10 +63,6 @@ export class Tree<T = {}> extends React.Component<ITreeProps<T>, {}> { | |||
|
|
|||
| private nodeRefs: { [nodeId: string]: HTMLElement } = {}; | |||
|
|
|||
| constructor(props?: ITreeProps<T>, context?: any) { | |||
There was a problem hiding this comment.
@izikorgad optional props is not compatible with React typings in strict mode, so we simply have to define the props argument in all the constructor types.
fix ofType syntaxPreview: documentation | landing | table |
fix DRP test flake?Preview: documentation | landing | table |
actually fix DRP testPreview: documentation | landing | table |
adidahiya
approved these changes
Mar 7, 2018
This was referenced Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2132 (comment) pointed out a bug in how we were defining our
ofTypemethods for generic components. This PR fixes all usages.cc @izikorgad