[TagInput] leftIconName + rightElement #1420
Conversation
rightElement appears as last childPreview: documentation |
|
@giladgray can we also add support for |
|
FYI Clear button doesn't look centered in the button in your screenshot: |
| } | ||
| const iconClass = classNames( | ||
| Classes.TAG_INPUT_ICON, | ||
| useLarge ? CoreClasses.ICON_LARGE : CoreClasses.ICON_STANDARD , |
There was a problem hiding this comment.
nit: no space before comma
ugh remove spacePreview: documentation |
|
addressed all the issues: button centering and padding and whitespace. @cmslewis i poked around |
| @@ -9,39 +9,56 @@ | |||
| @import "~@blueprintjs/core/src/components/forms/common"; | |||
| @import "~@blueprintjs/core/src/components/tag/common"; | |||
|
|
|||
| $tag-input-padding: ($pt-input-height - $tag-height) / 2; | |||
| $ti-padding: ($pt-input-height - $tag-height) / 2; | |||
| $ti-right-padding: ($pt-input-height - $pt-button-height-small) / 2; | |||
There was a problem hiding this comment.
So much nicer with this added 👏 Perfectly squared off. $tag-input- ain't that long is it?
How about -right-padding -> -padding-right to match the property name?
scss variable namePreview: documentation |
|
update: removed that commit, moving to separate PR. my bad ✨ |
giladgray
force-pushed
the
gg/taginput-left-right
branch
from
61ba3c0 to
dee48b0
Compare
fix testPreview: documentation |
Addresses #1412
Changes proposed in this pull request:
leftIconNamerenders an icon as first childrightElementappears as last childInputGroup