[TagInput] add separator, onChange, placeholder props #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 6, 2017 13:08
🔥 `onAdd` now receives `string[]` instead of single `string`!
TagInput placeholder prop appears only when values is emptyPreview: documentation |
cmslewis
approved these changes
Aug 7, 2017
| } | ||
| } | ||
|
|
||
| /** Invokes `onAdd` and `onChange` accordingly to remove the item at the given index. */ |
packages/labs/test/tagInputTests.tsx
Outdated
| const value = "one, two, three"; | ||
| const onAdd = sinon.stub(); | ||
| const wrapper = mountTagInput(onAdd, { separator: false }); | ||
| // extra spaces to exercise `\s*` in regexp |
There was a problem hiding this comment.
Can we delete this comment?
llorca
approved these changes
Aug 7, 2017
better comments + value splitting ⚛️Preview: documentation |
update docs for new props, default separator just ","Preview: documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1412
Changes proposed in this pull request:
separatorprop allows adding multiple entries at onceonChangeprop combinesonAddandonRemovefor easy controlling (and implements basic array manipulation logic)placeholderprop appears only whenvaluesis emptyinputProps.placeholderif you want it to appear all the timeonAddnow receivesstring[]instead of singlestringReviewers should focus on: