Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog component does not cleanup the overlay's side effects on redirects without onClose #6752

Closed
yuliiakorabelska opened this issue Mar 27, 2024 · 0 comments · Fixed by #6753
Closed

Dialog component does not cleanup the overlay's side effects on redirects without onClose #6752

yuliiakorabelska opened this issue Mar 27, 2024 · 0 comments · Fixed by #6753
Labels
help wanted Package: core Type: bug

Comments

@yuliiakorabelska
Copy link

yuliiakorabelska commented Mar 27, 2024 •
edited
Loading

Environment

  • Package version(s): 5.7.2
  • Operating System: MacOS 14.4
  • Browser name and version: Google Chrome Version 123.0.6312.59 (Official Build) (arm64)

Code Sandbox

Link to a minimal repro: repro

Steps to reproduce

  1. Open dialog
  2. Click on the "Main page" href inside the dialog

Actual behavior

Main page has bp5-overlay-open class that prevents scroll across the app

Expected behavior

Scroll is still working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Package: core Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix cleanup for overlay2 component maxpolski/blueprint
3 participants
@invliD @ericjeney @yuliiakorabelska