Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumericInput button icons should have <title> for a11y #4527

Closed
adidahiya opened this issue Feb 16, 2021 · 0 comments · Fixed by #4836
Closed

NumericInput button icons should have <title> for a11y #4527

adidahiya opened this issue Feb 16, 2021 · 0 comments · Fixed by #4836
Assignees
@evansjohnson
Labels
Domain: accessibility help wanted P2 Package: core

Comments

@adidahiya
Copy link
Contributor

adidahiya commented Feb 16, 2021 •
edited
Loading

Feature request

There are some cases where BP's built-in components could use better accessibility for icons. We decided a while ago in #3214 that not all icons should get tooltips, but in cases like this where there is no label for the icon, I think it makes sense to add one by default.

Expected behavior

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evansjohnson evansjohnson

Labels
Domain: accessibility help wanted P2 Package: core
Projects
UX paper cuts
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] fix: add aria-label to some buttons evansjohnson/blueprint
2 participants
@adidahiya @evansjohnson