Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog goes over sticky header in documentation #450

Closed
leebyp opened this issue Jan 11, 2017 · 3 comments
Closed

Dialog goes over sticky header in documentation #450

leebyp opened this issue Jan 11, 2017 · 3 comments
Assignees
Milestone

Comments

@leebyp
Copy link
Contributor

leebyp commented Jan 11, 2017

As shown:

screen shot 2017-01-10 at 17 36 50

@llorca
Copy link
Contributor

llorca commented Jan 11, 2017

Not a problem, dialogs have a higher z-index than anything else on purpose. I do wonder if it's that useful to show a static dialog without its backdrop

@leebyp
Copy link
Contributor Author

leebyp commented Jan 11, 2017

It's useful to see what the CSS API produces inline as a quick reference without needing to click the button in the JS API. The dialog should have a high z-index in general, but I don't think it should specifically for this purpose in the documentation, and we should override it. It just looks bad when you're scrolling through the docs.

@giladgray
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants