Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon SVG-download links are broken in docs #268

Closed
cmslewis opened this issue Nov 29, 2016 · 2 comments
Closed

Icon SVG-download links are broken in docs #268

cmslewis opened this issue Nov 29, 2016 · 2 comments
Assignees
@cmslewis
Labels
Status: work in progress

Comments

@cmslewis
Copy link
Contributor

Bug Report

  • Package version(s): v1.1.0
  • Browser and OS versions: Chrome 54.0.2840.98, Mac OS X 10.11.6

Describe the issue:

These links don't work on http://blueprintjs.com/docs/#icons:

image

They take you to a link with the following format, which shows a 404 page on github.com:
https://github.com/palantir/blueprint/blob/develop/resources/icons/{16,20}px/pt-icon-*.svg

Expected behavior:

Clicking the "Download 16px SVG" should download the 16px SVG for that icon. Same for 20px.
@cmslewis cmslewis self-assigned this Nov 30, 2016
@cmslewis cmslewis mentioned this issue Nov 30, 2016
Merged
2 tasks
@giladgray
Copy link
Contributor

yep should be .../blob/master/resources/...

@giladgray
Copy link
Contributor

giladgray commented Nov 30, 2016 •
edited
Loading

in the future, no need to make an issue if you're going to open the PR fix immediately afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmslewis cmslewis

Labels
Status: work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmslewis @giladgray