Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visual design of truncated cell content #232

Closed
adidahiya opened this issue Nov 23, 2016 · 1 comment
Closed

Improve visual design of truncated cell content #232

adidahiya opened this issue Nov 23, 2016 · 1 comment

Comments

@adidahiya
Copy link
Contributor

adidahiya commented Nov 23, 2016

A request for micro-interaction design review

In a table that uses <JSONFormat> to render cell contents, it's easy to produce columns that look like this:

image
image

To an user, it can be confusing why some cells use normal ellipses + a browser tooltip and others have a fancy popover that renders longer content. In the source code, it is clear that this truncation threshold is 80 characters, and you get into this undesirable state when columns are < 80 chars wide while content length hovers above and below 80 chars.

No clean solution jumps out to me. Changing the truncation threshold might help, but feels a bit like a band-aid. Some ideas:

  • Change the "..." icon that triggers the popover
  • Never use text-overflow truncation & browser tooltips with <JSONFormat> -- instead always use the fancy popover

Thoughts?

@llorca
Copy link
Contributor

llorca commented Nov 28, 2016

Just talked to Bill, we propose using the fancy popover truncation not just for JSON cells anymore, but for any type of cells. That will make the interaction consistent across all cells that are truncated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants