Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGTooltip no longer exists in 2.0 #2250

Closed
tgreen7 opened this issue Mar 15, 2018 · 7 comments · Fixed by #2276
Closed

SVGTooltip no longer exists in 2.0 #2250

tgreen7 opened this issue Mar 15, 2018 · 7 comments · Fixed by #2276

Comments

@tgreen7
Copy link
Contributor

tgreen7 commented Mar 15, 2018

What should we use instead?

@giladgray
Copy link
Contributor

giladgray commented Mar 15, 2018

@tgreen7 yeah we killed it because it wasn't helping us anymore. you should be able to use regular Tooltip with rootElementTag prop (that's all SVGTooltip ever was). please let us know if you see warnings, but we have no plans to bring the component back.

@tgreen7
Copy link
Contributor Author

tgreen7 commented Mar 15, 2018

@giladgray we tried with rootElementTag="g". It is making the pt-popover-wrapper a g element but the pt-popover-target is a div, so the whole thing just isn't showing up.

@giladgray
Copy link
Contributor

@tgreen7 happy to accept a PR here, but this is not a priority for the team.

@tgreen7
Copy link
Contributor Author

tgreen7 commented Mar 19, 2018

@giladgray I looked at react-popper and received this response floating-ui/react-popper#107. So if blueprintjs just added the ability to pass a component prop to the Target in popper (maybe a targetComponent prop to Tooltip or Popover), then that would help solve this issue. (sorry but I don't really know how to go about opening a pr here / typescript)

@tgreen7
Copy link
Contributor Author

tgreen7 commented Mar 19, 2018

@giladgray I think I have found the solution. Do I have to fork blueprint to create the pr?

@giladgray
Copy link
Contributor

@tgreen7 indeed you do

@giladgray
Copy link
Contributor

closed in #2276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants