Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking menu item in docs v1 cycles through items #2171

Closed
imawuman opened this issue Feb 21, 2018 · 6 comments
Closed

Clicking menu item in docs v1 cycles through items #2171

imawuman opened this issue Feb 21, 2018 · 6 comments

Comments

@imawuman
Copy link

blueprintdocs

@imawuman
Copy link
Author

Couldn't find existing so created new one

@adidahiya
Copy link
Contributor

same as #2148, but that one was prematurely closed. It's clear that this is still an issue in the v1 docs.

@will-stone
Copy link
Contributor

I've found the same issue on v2 docs too, using Firefox 58.

@danielbh
Copy link
Contributor

The culprit seems to be here. When you set the offset argument which is currently 100 to 122 or greater the bug appears fixed. I believe it has something to do with the fact that .docs-anchor elements have -120 top-margin. I haven't submitted a PR because I still have no idea why this bug is happening, only what appears to fix it. What are your thoughts @adidahiya ?

@danielbh
Copy link
Contributor

danielbh commented Mar 13, 2018

To add to that 121 works most of the time, but not for these two links.
screen shot 2018-03-12 at 11 00 02 pm

@giladgray giladgray added this to the 2.0.0 milestone Mar 13, 2018
@giladgray giladgray self-assigned this Mar 13, 2018
@giladgray
Copy link
Contributor

fixed in #2237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants