Make HotkeysDialog not inline (#380)

palantir · Dec 16, 2016 · 5bfdb47 · 5bfdb47 · blueprint-bot · Dec 16, 2016
1 parent 7a6fba3
commit 5bfdb47
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/core/src/components/hotkeys/hotkeysDialog.tsx b/packages/core/src/components/hotkeys/hotkeysDialog.tsx
@@ -91,7 +91,6 @@ class HotkeysDialog {
             <Dialog
                 {...this.componentProps}
                 className={classNames(this.componentProps.className, "pt-hotkey-dialog")}
-                inline
                 isOpen={this.isDialogShowing}
                 onClose={this.hide}
             >

diff --git a/packages/core/test/hotkeys/hotkeysTests.tsx b/packages/core/test/hotkeys/hotkeysTests.tsx
@@ -113,7 +113,7 @@ describe("Hotkeys", () => {
             assertInputAllowsKeys("radio", true);
         });
 
-        it("triggers hotkey dialog with \"?\"", (done) => {
+        it("triggers non-inline hotkey dialog with \"?\"", (done) => {
             const TEST_TIMEOUT_DURATION = 30;
 
             comp = mount(<TestComponent />, { attachTo });
@@ -124,6 +124,7 @@ describe("Hotkeys", () => {
             // wait for the dialog to animate in
             setTimeout(() => {
                 expect(document.querySelector(".pt-hotkey-column")).to.exist;
+                expect(document.querySelector(".pt-overlay-open").classList.contains("pt-overlay-inline")).to.be.false;
                 hideHotkeysDialog();
                 comp.detach();
                 attachTo.remove();