diff --git a/atlasdb-client/src/main/java/com/palantir/atlasdb/AtlasDbMetricNames.java b/atlasdb-client/src/main/java/com/palantir/atlasdb/AtlasDbMetricNames.java index 5428922a6bd..ef9a1e9e462 100644 --- a/atlasdb-client/src/main/java/com/palantir/atlasdb/AtlasDbMetricNames.java +++ b/atlasdb-client/src/main/java/com/palantir/atlasdb/AtlasDbMetricNames.java @@ -37,7 +37,6 @@ private CellFilterMetrics() { public static final String SNAPSHOT_TRANSACTION_CELLS_RETURNED = "numCellsReturnedAfterFiltering"; public static final String SNAPSHOT_TRANSACTION_TOO_MANY_BYTES_READ = "tooManyBytesRead"; public static final String SNAPSHOT_TRANSACTION_BYTES_WRITTEN = "bytesWritten"; - public static final String NUMBER_OF_TRANSACTIONS_READ_FROM_DB = "transactionsReadFromDB"; public static final String CELLS_EXAMINED = "cellTimestampPairsExamined"; public static final String CELLS_SWEPT = "staleValuesDeleted"; diff --git a/atlasdb-impl-shared/src/main/java/com/palantir/atlasdb/transaction/impl/SnapshotTransaction.java b/atlasdb-impl-shared/src/main/java/com/palantir/atlasdb/transaction/impl/SnapshotTransaction.java index 909d90991dd..fbe1ae1fe0c 100644 --- a/atlasdb-impl-shared/src/main/java/com/palantir/atlasdb/transaction/impl/SnapshotTransaction.java +++ b/atlasdb-impl-shared/src/main/java/com/palantir/atlasdb/transaction/impl/SnapshotTransaction.java @@ -2246,8 +2246,6 @@ protected ListenableFuture> getCommitTimestamps( logLargeNumberOfTransactions(tableRef, gets); } - getHistogram(AtlasDbMetricNames.NUMBER_OF_TRANSACTIONS_READ_FROM_DB, tableRef).update(gets.size()); - return Futures.transform(loadCommitTimestamps(asyncTransactionService, gets), rawResults -> { for (Map.Entry e : rawResults.entrySet()) { diff --git a/changelog/@unreleased/pr-4838.v2.yml b/changelog/@unreleased/pr-4838.v2.yml new file mode 100644 index 00000000000..3fb92d1b497 --- /dev/null +++ b/changelog/@unreleased/pr-4838.v2.yml @@ -0,0 +1,9 @@ +type: improvement +improvement: + description: 'AtlasDB no longer publishes `transactionsReadFromDB`: it was a high + cardinality metric of limited value. Consider using `TransactionService.get` if + attempting to determine the total number of start-commit timestamp mappings looked + up from the transactions tables. Otherwise, consider enabling TRACE logging to + get this data.' + links: + - https://github.com/palantir/atlasdb/pull/4838