diff --git a/changelog/@unreleased/pr-5516.v2.yml b/changelog/@unreleased/pr-5516.v2.yml new file mode 100644 index 00000000000..a5c93354d3a --- /dev/null +++ b/changelog/@unreleased/pr-5516.v2.yml @@ -0,0 +1,5 @@ +type: fix +fix: + description: "Upgrade AssertJ to 3.20.2 to fix ABI compatibility breaks." + links: + - https://github.com/palantir/atlasdb/pull/5516 diff --git a/timelock-server/src/integTest/java/com/palantir/atlasdb/timelock/LockWatchValueIntegrationTest.java b/timelock-server/src/integTest/java/com/palantir/atlasdb/timelock/LockWatchValueIntegrationTest.java index 89e78c08ed1..f7dccef12f2 100644 --- a/timelock-server/src/integTest/java/com/palantir/atlasdb/timelock/LockWatchValueIntegrationTest.java +++ b/timelock-server/src/integTest/java/com/palantir/atlasdb/timelock/LockWatchValueIntegrationTest.java @@ -159,15 +159,7 @@ public void readWriteTransactionsPublishValuesToCentralCache() { assertThat(result).containsEntry(CELL_1, DATA_1); assertThat(result).containsEntry(CELL_4, DATA_2); - - // Cannot use containsExactlyInAnyOrderEntriesOf assertj regression in 3.20.0 with map entry comparisons, - // see https://github.com/assertj/assertj-core/issues/2264 & https://github.com/assertj/assertj-core/pull/2265 - // assertThat(result).containsExactlyInAnyOrderEntriesOf(result2); - assertThat(result.keySet()).isEqualTo(result2.keySet()); - assertThat(result.values()).hasSameElementsAs(result2.values()); - assertThat(result).hasSameSizeAs(result2).containsAllEntriesOf(result2); - assertThat(result).containsAllEntriesOf(result2); - assertThat(result2).containsAllEntriesOf(result); + assertThat(result).containsExactlyInAnyOrderEntriesOf(result2); } @Test diff --git a/versions.lock b/versions.lock index cc595a4e8bb..68f27687850 100644 --- a/versions.lock +++ b/versions.lock @@ -99,8 +99,8 @@ com.palantir.refreshable:refreshable:1.2.0 (3 constraints: 6629eaf1) com.palantir.remoting2:error-handling:2.6.3 (2 constraints: 3f15c2ba) com.palantir.remoting2:jackson-support:2.6.3 (2 constraints: 571dfe30) com.palantir.ri:resource-identifier:1.2.0 (3 constraints: 992fff33) -com.palantir.safe-logging:preconditions:1.15.0 (28 constraints: b0ddf714) -com.palantir.safe-logging:safe-logging:1.15.0 (23 constraints: 417fd943) +com.palantir.safe-logging:preconditions:1.16.0 (28 constraints: b2ddfa1b) +com.palantir.safe-logging:safe-logging:1.16.0 (23 constraints: 447f744b) com.palantir.safethreadlocalrandom:safe-thread-local-random:0.1.0 (3 constraints: 933225f9) com.palantir.sls.versions:sls-versions:0.14.0 (1 constraints: 37052f3b) com.palantir.tokens:auth-tokens:3.8.1 (5 constraints: 5c5bc41a) @@ -202,7 +202,7 @@ org.apache.httpcomponents.client5:httpclient5:5.0.3 (1 constraints: cc13926e) org.apache.httpcomponents.core5:httpcore5:5.1 (3 constraints: fb38c8bc) org.apache.httpcomponents.core5:httpcore5-h2:5.0.2 (1 constraints: 3b13053c) org.apache.thrift:libthrift:0.9.2 (3 constraints: 6d318be9) -org.assertj:assertj-core:3.20.1 (4 constraints: a339b205) +org.assertj:assertj-core:3.20.2 (4 constraints: a6399e06) org.awaitility:awaitility:4.0.3 (2 constraints: c81ac33b) org.caffinitas.ohc:ohc-core:0.3.4 (1 constraints: 950f6988) org.checkerframework:checker-compat-qual:2.5.3 (2 constraints: 1b1dbd16) @@ -310,7 +310,7 @@ com.h2database:h2:1.4.190 (1 constraints: 7105af40) com.palantir.conjure.java.api:test-utils:2.18.0 (1 constraints: 3c05443b) com.palantir.remoting2:jersey-servers:2.6.3 (1 constraints: 0d050a36) com.palantir.remoting2:tracing:2.6.3 (1 constraints: 3310819c) -com.palantir.safe-logging:preconditions-assertj:1.15.0 (1 constraints: 3905383b) +com.palantir.safe-logging:preconditions-assertj:1.16.0 (1 constraints: 3a053b3b) com.palantir.tracing:tracing-test-utils:4.21.0 (1 constraints: 3905423b) com.spotify.dataenum:dataenum:1.3.2 (1 constraints: e91058c1) com.thoughtworks.qdox:qdox:1.12.1 (1 constraints: 6d11f7d9) diff --git a/versions.props b/versions.props index 05af4ba2bf8..259262df432 100644 --- a/versions.props +++ b/versions.props @@ -25,7 +25,7 @@ com.palantir.dialogue:* = 1.118.1 com.palantir.docker.compose:docker-compose-rule* = 1.5.0 com.palantir.docker.proxy:docker-proxy-rule* = 1.1.1 com.palantir.remoting2:* = 2.6.3 -com.palantir.safe-logging:* = 1.15.0 +com.palantir.safe-logging:* = 1.16.0 com.palantir.sls.versions:* = 0.14.0 com.palantir.tracing:* = 4.21.0 com.palantir.tritium:* = 0.18.8 @@ -40,7 +40,7 @@ net.jcip:jcip-annotations = 1.0 one.util:streamex = 0.7.3 org.apache.commons:commons-pool2 = 2.9.0 org.apache.commons:commons-lang3 = 3.12.0 -org.assertj:assertj-* = 3.20.1 +org.assertj:assertj-* = 3.20.2 org.awaitility:awaitility = 4.0.3 org.clojure:clojure = 1.8.0 org.derive4j:* = 1.1.1