Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuration-properties.names #456

Open
tinedel opened this issue Mar 27, 2024 · 0 comments
Open

Add support for configuration-properties.names #456

tinedel opened this issue Mar 27, 2024 · 0 comments

Comments

@tinedel
Copy link
Contributor

tinedel commented Mar 27, 2024

Describe the Enhancement

According to the dataflow documentation two properties are supported configuration-properties.classes and configuration-properties.names in the dataflow-configuration-metadata.properties file. This buildpack support only the first one - classes, completely ignoring names.

It would be nice to be able to specify also names.

Possible Solution

There is a question which is not quite clear to me. From what I can see in the documentation names and classes are additive. If my understanding is correct then the solution is as follows:

In boot/congifuration_metadata.go in NewDataFlowConfigurationMetadata function add a section to process names. It will need to iterate through properties, hints, and groups and add matching properties to Properties, Hints, and Groups respectively.

Motivation

While looking for a class mapping corresponding property and adding the class itself to the configuration-properties.classes property is a viable workaround, this path is confusing and to my best knowledge undocumented. Adding this feature will save a lot of hair loss to future users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant