Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action fixes #681

Merged
merged 1 commit into from
May 10, 2022
Merged

Action fixes #681

merged 1 commit into from
May 10, 2022

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented May 10, 2022

Summary

  1. Not a bug, but for code clarity consistently use 'version' in dragonwell action
  2. Panic when we can't parse a version from the Foojay API. This should not happen, just printing could result in missing errors.
  3. Modify graalvm to pull the Java version even for native image installable downloads. This is consistent with past behavior.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Action fixes
eb306ab 
1. Not a bug, but for code clarity consistently use 'version' in dragonwell action
2. Panic when we can't parse a version from the Foojay API. This should not happen, just printing could result in missing errors.
3. Modify graalvm to pull the Java version even for native image installable downloads. This is consistent with past behavior.

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels May 10, 2022
@dmikusa dmikusa requested a review from a team May 10, 2022 15:01
@pivotal-david-osullivan pivotal-david-osullivan merged commit 4eceafe into main May 10, 2022
@pivotal-david-osullivan pivotal-david-osullivan deleted the action-fixes branch May 10, 2022 15:14
This was referenced May 25, 2022
Merged
Merged
This was referenced May 25, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@mboldt mboldt mentioned this pull request May 25, 2022
Open
This was referenced May 25, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 25, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@paketo-bot paketo-bot mentioned this pull request Jun 16, 2022
Merged
@paketo-bot paketo-bot mentioned this pull request Jul 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivotal-david-osullivan pivotal-david-osullivan pivotal-david-osullivan approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmikusa @pivotal-david-osullivan