Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tomee-dependency action to track apache-tomee #546

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

garethjevans
Copy link
Contributor

@garethjevans garethjevans commented Feb 9, 2022

Summary

New apache-tomee releases are displayed on the page https://archive.apache.org/dist/tomee, we need to parse the html to be able to get the correct link to download the latest version and sha256.

Use Cases

Currently working on an Apache Tomee buildpack that I'd like to get moved across to paketo buildpacks. The tomee dependencies need to be updated in a similar way to the tomcat-dependency action.

Notes for the reviewer:
Tomee v9 is pre-release only, I've had to change how the version is outputted to use the full version rather than major.minor.patch - I'm not entirely sure how pre-releases were working before this?

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@garethjevans garethjevans requested a review from a team February 9, 2022 12:04
@dmikusa dmikusa added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Feb 9, 2022
@dmikusa dmikusa merged commit 030073e into paketo-buildpacks:main Feb 9, 2022
This was referenced Feb 9, 2022
This was referenced Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants