Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Logger to os.Stdout #276

Conversation

c0d1ngm0nk3y
Copy link
Contributor

fixes #46

Summary

Uses Stdout as default log target.

Use Cases

By default, the bard.Logger is an empty object and does not log anything. Adding the logger to the factory function, is not really an option since it would be incompatible and need a major version bump. This change makes sure that the logs are at least written to stdout by default and since Logger is public, it can then be modified.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team as a code owner August 4, 2023 14:00
@c0d1ngm0nk3y
Copy link
Contributor Author

Apparently it is somehow expected to hide log messages by default (see comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewLayerContributor does not log expected logs
1 participant