Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[memory_calculator] Counting classes from classpath #348

Open
qiaoleiatms opened this issue Dec 15, 2023 · 0 comments
Open

[memory_calculator] Counting classes from classpath #348

qiaoleiatms opened this issue Dec 15, 2023 · 0 comments
Labels
note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:bug A general bug

Comments

@qiaoleiatms
Copy link

qiaoleiatms commented Dec 15, 2023

Currently, the calculation of metaspace size depends on the class count of JVM, application, agent and the adjustment (static/factor)

totalClasses := float64(jvmClassCount+appClassCount+agentClassCount+staticAdjustment) * (float64(adjustmentFactor) / 100.0)

But the 3rd party libraries introduced from classpath are no included, for example, below is a screenshot from a tomcat app:
image

Expected Behavior

Should take the libraries from classpath into count

Current Behavior

Not included

Steps to Reproduce

pack build a war project such as spring-framework-petclinic with the paketo java buildpacks

Motivations

The metaspace size may not correct or enough for a java project which introduces libraries with a large size from classpath

@dmikusa dmikusa added type:bug A general bug note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with labels Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants