-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky dependency version retrieval #344
Comments
This appears to be a common issue across almost all of the repos that retrieve from GitHub. We aren't using an API token when we make the request and so in some cases we get rate-limited. |
Some examples of errors I've seen:
|
the second failure mode seems entirely consistent with rate-limiting. The first might be unrelated - just a bad response |
I think the first case shows up in instances where we aren't checking the status code, so we don't error on a 403 and then try to unmarshal a JSON response that doesn't match our struct and error out. |
Also related: paketo-buildpacks/github-config#653 That issue won't cover buildpack-specific dependency code, but it does cover the same types of failure modes in the common tooling. |
Also joshuatcasey/libdependency#25 will fix this issue for buildpacks that use libdependency (e.g. passenger) |
Expected Behavior
Dependency workflow version retrieval should work seamlessly.
Current Behavior
The retrieval step fails every few days with a flake, see #336, and the passes again.
It would be great if we could figure out what the issue is and make that code more resilient so we have less toil associated with dependency workflow failures
The text was updated successfully, but these errors were encountered: