Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle GraalVM version? #210

Open
matus-gazo opened this issue Apr 8, 2022 · 9 comments
Open

Oracle GraalVM version? #210

matus-gazo opened this issue Apr 8, 2022 · 9 comments
Labels
type:enhancement A general enhancement

Comments

@matus-gazo
Copy link

Hi there,

I want to use the Enterprise version with the buildpack to use PGO a G1 GC, but it seems there's no way to do that with the buildpack, which pretty much ruins the build pipeline I've set up for our product. Is there any way or any plans to be able to do this?

@dmikusa dmikusa added the type:enhancement A general enhancement label Apr 11, 2022
@dmikusa
Copy link
Contributor

dmikusa commented Apr 11, 2022

You are correct that we do not currently support the enterprise version of GraalVM.

I think the biggest challenge is with the way Oracle distributes it. From what I can tell on their site, it's behind a EULA and user login. The buildpack needs to be able to download the software it installs, so while not impossible, that makes things more difficult.

I wouldn't be opposed to adding support for it, but we'll have to figure out a way for the buildpack to get the software. That would likely require you, as a user, to download the software and host it somewhere internally/private that the buildpack can access. This way the buildpack doesn't need to worry about the Oracle site. Would this work for you?

Or are you aware if Oracle provides an API through which we could download the binaries or some alternative channel for downloads?

Thanks

@dmikusa
Copy link
Contributor

dmikusa commented Oct 27, 2022

It looks like GraalVM has a way to download EE versions, we should be able to do the same thing with the buildpack. See https://medium.com/graalvm/one-line-graalvm-jdk-downloads-91ee8d4e6ffd.

There's a bash script to download, but I think we can just reimplement what it's doing in Go. There's a token it's grabbing and a file it's downloading. Shouldn't be too hard.

@lgklein
Copy link

lgklein commented Mar 31, 2023

Hello @dmikusa, we have any ETA for this to be incorporate? This is a really welcome feature for company's builds...

@dmikusa
Copy link
Contributor

dmikusa commented Apr 3, 2023

@lgklein I can tell you that this is not something we've discussed implementing as a team, but that we'd be happy to help if anyone wants to contribute a PR for this. Just let me know, and I can provide an outline of what needs to be done.

@danthe1st
Copy link

Oracle has introduced a new license changing the name of GraalVM Enterprise Edition to Oracle GraalVM and making it available for free (depending on the version).

@dmikusa
Copy link
Contributor

dmikusa commented Jun 15, 2023

Oh, interesting. Thanks for sharing!

@danthe1st
Copy link

danthe1st commented Jun 15, 2023

Also, there are script-friendly download URLs for it now which might make the implementation of this here easier.

@sdeleuze
Copy link

Could we maybe rename this issue to something like "Oracle GraalVM support" or something approaching, to match the new naming?

@dmikusa dmikusa changed the title GraalVM Enterprise version? ~GraalVM Enterprise~ Oracle GraalVM version? Jun 26, 2023
@dmikusa dmikusa changed the title ~GraalVM Enterprise~ Oracle GraalVM version? Oracle GraalVM version? Jun 26, 2023
@dmikusa
Copy link
Contributor

dmikusa commented Jul 27, 2023

If you want to be involved in this conversation, we're discussing and planning this on the following RFC: paketo-buildpacks/rfcs#294

Comments and feedback is appreciated. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants