Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness of stack get USNs action #641

Open
robdimsdale opened this issue Dec 12, 2022 · 0 comments
Open

Improve robustness of stack get USNs action #641

robdimsdale opened this issue Dec 12, 2022 · 0 comments

Comments

@robdimsdale
Copy link
Member

In the action that retrieves Stack USNS, we have retry handling with exponential backoff for HTTP errors, but occasionally we see other types of errors that likely would succeed on retry (e.g. Get "https://ubuntu.com/security/notices/rss.xml": net/http: TLS handshake timeout).

We should include these types of errors in the retry handling, so as to improve the robustness of the action.

As an implementation note, the underlying library defines HTTPError but not other errors (e.g. transport errors like the one above). So we'd probably have to do the type assertion (errors.As()) on the net/http error type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant