Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Carta Giovani Nazionale): [#177458070] Bonuses Available list now follows the same logic of bonuses in carousel #2960

Merged
merged 3 commits into from
Apr 8, 2021

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR converts the logic of visualization/press handling of the bonus item in Available List screen that prevented the press event if a bonus is in experimental state.

@pagopa-github-bot pagopa-github-bot changed the title [#177458070] Bonuses Available list now follows the same logic of bonuses in carousel feat(Carta Giovani Nazionale): [#177458070] Bonuses Available list now follows the same logic of bonuses in carousel Apr 2, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Apr 2, 2021

Affected stories

  • 🌟 #177458070: Come DEV vorrei poter rendere l'item nella lista dei bonus tappabile in beta senza attivare globalmente il bonus

Generated by 🚫 dangerJS against b617309

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #2960 (b617309) into master (40207f7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2960   +/-   ##
=======================================
  Coverage   58.79%   58.79%           
=======================================
  Files         909      909           
  Lines       25023    25020    -3     
  Branches     4620     4619    -1     
=======================================
- Hits        14712    14711    -1     
+ Misses      10215    10213    -2     
  Partials       96       96           
Impacted Files Coverage Δ
...onus/bonusVacanze/screens/AvailableBonusScreen.tsx 45.71% <ø> (+0.50%) ⬆️
...nusVacanze/store/reducers/availableBonusesTypes.ts 80.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40207f7...b617309. Read the comment docs.

@Undermaken Undermaken merged commit 2769d72 into master Apr 8, 2021
@Undermaken Undermaken deleted the 177458070-fix-bonus-list-item branch April 8, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants