Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [#177560562] Close NFC dialog when card is successfully read #2948

Merged
merged 5 commits into from
Apr 7, 2021

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Mar 30, 2021

Short description

This PR upgrades the react-native-cie to 1.0.4. That version dismisses immediately the nfc reader dialog when the CIE authentication is successfully completed

before

primacut.mp4

after

dopocut.mp4

@Undermaken Undermaken added the ios label Mar 30, 2021
@pagopa-github-bot pagopa-github-bot changed the title [#177560562] Close NFC dialog when card is successfully read chore: [#177560562] Close NFC dialog when card is successfully read Mar 30, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Mar 30, 2021

Affected stories

  • ⚙️ #177560562: Aggiornare react-native-cie per includere la fix sul tempo di attesa quando la CIE è letta correttamente

Generated by 🚫 dangerJS against ad33f69

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #2948 (ad33f69) into master (b85831f) will decrease coverage by 2.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2948      +/-   ##
==========================================
- Coverage   58.79%   56.61%   -2.18%     
==========================================
  Files         909      907       -2     
  Lines       25023    24989      -34     
  Branches     4620     4613       -7     
==========================================
- Hits        14712    14148     -564     
- Misses      10215    10748     +533     
+ Partials       96       93       -3     
Impacted Files Coverage Δ
ts/features/bonus/bpd/utils/dates.ts 11.11% <0.00%> (-88.89%) ⬇️
ts/sagas/wallet/cobadgeReminder.ts 30.00% <0.00%> (-70.00%) ⬇️
...eens/details/transaction/BpdTransactionsScreen.tsx 37.83% <0.00%> (-62.17%) ⬇️
...sagas/services/handleOrganizationNameUpdateSaga.ts 43.75% <0.00%> (-56.25%) ⬇️
ts/utils/convertDateToWordDistance.ts 28.00% <0.00%> (-52.00%) ⬇️
...ge/screens/search/SearchAvailableCoBadgeScreen.tsx 48.21% <0.00%> (-51.79%) ⬇️
ts/store/reducers/userMetadata.ts 42.85% <0.00%> (-47.62%) ⬇️
...tures/wallet/cobadge/component/BaseCoBadgeCard.tsx 53.33% <0.00%> (-46.67%) ⬇️
ts/store/storages/keychain.ts 55.55% <0.00%> (-44.45%) ⬇️
.../wallet/cobadge/component/CobadgeWalletPreview.tsx 57.14% <0.00%> (-42.86%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85831f...ad33f69. Read the comment docs.

@fabriziofff fabriziofff merged commit 7859770 into master Apr 7, 2021
@fabriziofff fabriziofff deleted the 177560562-fix-ios-cie-auth-delay branch April 7, 2021 15:42
fabriziofff pushed a commit that referenced this pull request Apr 7, 2021
Undermaken added a commit that referenced this pull request Apr 7, 2021
…s successfully read (#2948)" (#2967)

This reverts commit 7859770.

Co-authored-by: Matteo Boschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants