-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [#177560562] Close NFC dialog when card is successfully read #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undermaken
requested review from
CrisTofani,
debiff and
fabriziofff
as code owners
March 30, 2021 14:04
pagopa-github-bot
changed the title
[#177560562] Close NFC dialog when card is successfully read
chore: [#177560562] Close NFC dialog when card is successfully read
Mar 30, 2021
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2948 +/- ##
==========================================
- Coverage 58.79% 56.61% -2.18%
==========================================
Files 909 907 -2
Lines 25023 24989 -34
Branches 4620 4613 -7
==========================================
- Hits 14712 14148 -564
- Misses 10215 10748 +533
+ Partials 96 93 -3
Continue to review full report at Codecov.
|
fabriziofff
approved these changes
Apr 7, 2021
Undermaken
added a commit
that referenced
this pull request
Apr 7, 2021
…s successfully read (#2948)" (#2967) This reverts commit 7859770. Co-authored-by: Matteo Boschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR upgrades the
react-native-cie
to1.0.4
. That version dismisses immediately the nfc reader dialog when the CIE authentication is successfully completedbefore
primacut.mp4
after
dopocut.mp4