chore(Carta Giovani Nazionale): [#177461712] Introduces the CGN Test overlay information #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
requested review from
debiff,
fabriziofff and
Undermaken
as code owners
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2934 +/- ##
==========================================
- Coverage 58.49% 58.12% -0.37%
==========================================
Files 902 861 -41
Lines 24737 23739 -998
Branches 4556 4420 -136
==========================================
- Hits 14469 13798 -671
+ Misses 10175 9848 -327
Partials 93 93
Continue to review full report at Codecov.
|
Undermaken
suggested changes
Mar 24, 2021
| * Temp overlay created to avoid ambiguity when test cgn versions are released. | ||
| * @constructor | ||
| */ | ||
| export const CgnTestOverlay: React.FunctionComponent = () => ( |
There was a problem hiding this comment.
This PR lgtm
What do you think about a refactoring?
Since CGN e BPD use two custom components for the same scope, could it be only one instead?
something like this
<BetaTestingOverlay title="🛠️ CGN TEST VERSION 🛠️" body="some body"/>
We should always show the app version so that component should include it as a footer.
body prop could be an optional string
<View style={styles.versionContainer} pointerEvents="box-none">
<Label style={styles.versionText}>{`TITLE`}</Label>
<Body style={styles.versionText}>{"optional body"}</Body>
<H5 style={styles.versionText}>{`${getAppVersion()}`}</H5>
</View>
cc @fabriziofff
Undermaken
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR introduces the CGN Test Overlay