Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#177244740] In the "co-badge add card to wallet" screen, the disclaimer bold text now does not always wrap #2911

Conversation

fabriziofff
Copy link
Contributor

Short description

This pr changes the behaviour of the disclaimer bold text, in order to avoid to always wrap.

Before After

@pagopa-github-bot pagopa-github-bot changed the title [#177244740] In the "co-badge add card to wallet" screen, the disclaimer bold text now does not always wrap feat(Bonus Pagamenti Digitali): [#177244740] In the "co-badge add card to wallet" screen, the disclaimer bold text now does not always wrap Mar 17, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Mar 17, 2021

Affected stories

  • 🌟 #177244740: Come CIT, quando aggiungo una carta co-badge, voglio che il testo disclaimer in grassetto non vada a capo sempre

Generated by 🚫 dangerJS against 0196c10

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #2911 (5f76b9c) into master (9040e89) will decrease coverage by 0.39%.
The diff coverage is n/a.

❗ Current head 5f76b9c differs from pull request most recent head 0196c10. Consider uploading reports for the commit 0196c10 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2911      +/-   ##
==========================================
- Coverage   58.37%   57.97%   -0.40%     
==========================================
  Files         883      882       -1     
  Lines       24250    24220      -30     
  Branches     4468     4468              
==========================================
- Hits        14156    14042     -114     
- Misses      10002    10087      +85     
+ Partials       92       91       -1     
Impacted Files Coverage Δ
...obadge/screens/add-account/AddCobadgeComponent.tsx 91.42% <ø> (ø)
...ative/screens/search/SearchPrivativeCardScreen.tsx 44.89% <0.00%> (-55.11%) ⬇️
...ding/privative/store/reducers/searchedPrivative.ts 48.14% <0.00%> (-51.86%) ⬇️
...oarding/privative/store/reducers/foundPrivative.ts 64.70% <0.00%> (-35.30%) ⬇️
...ivative/store/reducers/searchPrivativeRequestId.ts 57.89% <0.00%> (-31.58%) ⬇️
...g/privative/screens/search/LoadPrivativeSearch.tsx 50.00% <0.00%> (-23.92%) ⬇️
...reducers/entities/services/readStateByServiceId.ts 66.66% <0.00%> (-23.81%) ⬇️
...privative/screens/search/ko/PrivativeKoTimeout.tsx 61.11% <0.00%> (-19.45%) ⬇️
...g/privative/screens/add/AddPrivativeCardScreen.tsx 63.15% <0.00%> (-18.43%) ⬇️
ts/features/bonus/bpd/model/RemoteValue.ts 56.52% <0.00%> (-17.40%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9040e89...0196c10. Read the comment docs.

@Undermaken Undermaken merged commit 7315b64 into master Mar 17, 2021
@Undermaken Undermaken deleted the 177244740-fix-disclaimer-bold-text-for-cobadge-add-card-screen branch March 17, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants