Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Carta Giovani Nazionale): [#176959393,#177244360] Implements the screen to request and copy for an OTP code related to the CGN #2908

Merged
merged 11 commits into from
Mar 18, 2021

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR adds the screen to show and copy the OTP code generated for the user CGN to get a discount by conventioned merchants

Registrazione.schermo.2021-03-17.alle.10.02.09.mov

@pagopa-github-bot pagopa-github-bot changed the title [#176959393,#177244360] Implements the screen to ask and check for an OTP code related to the CGN feat(Carta Giovani Nazionale): [#176959393,#177244360] Implements the screen to ask and check for an OTP code related to the CGN Mar 17, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Mar 17, 2021

Affected stories

  • 🌟 #176959393: Come GIOVANE voglio consultare la pagina con il codice OTP generato
  • 🌟 #177244360: Come GIOVANE voglio consultare una bottom-sheet che mi spiega come urilizzare il codice otp

Generated by 🚫 dangerJS against 9c55fc3

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #2908 (9c55fc3) into master (485492d) will decrease coverage by 5.62%.
The diff coverage is 58.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2908      +/-   ##
==========================================
- Coverage   58.46%   52.84%   -5.63%     
==========================================
  Files         883      819      -64     
  Lines       24272    22810    -1462     
  Branches     4470     4234     -236     
==========================================
- Hits        14190    12053    -2137     
- Misses       9990    10689     +699     
+ Partials       92       68      -24     
Impacted Files Coverage Δ
ts/features/bonus/cgn/navigation/routes.ts 100.00% <ø> (ø)
ts/features/bonus/cgn/screens/CgnDetailScreen.tsx 69.76% <25.00%> (-2.33%) ⬇️
ts/features/bonus/cgn/screens/CgnOtpScreen.tsx 56.86% <56.86%> (ø)
...eatures/bonus/cgn/components/otp/OtpNotWorking.tsx 62.50% <62.50%> (ø)
...Vacanze/components/buttons/ButtonConfigurations.ts 88.88% <100.00%> (ø)
ts/features/bonus/cgn/navigation/actions.ts 100.00% <100.00%> (ø)
ts/features/bonus/cgn/navigation/navigator.ts 100.00% <100.00%> (ø)
ts/features/bonus/bpd/utils/dates.ts 11.11% <0.00%> (-88.89%) ⬇️
ts/utils/options.ts 25.00% <0.00%> (-75.00%) ⬇️
ts/store/reducers/entities/services/index.ts 21.70% <0.00%> (-70.55%) ⬇️
... and 182 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 485492d...9c55fc3. Read the comment docs.

@CrisTofani CrisTofani changed the title feat(Carta Giovani Nazionale): [#176959393,#177244360] Implements the screen to ask and check for an OTP code related to the CGN feat(Carta Giovani Nazionale): [#176959393,#177244360] Implements the screen to request and check for an OTP code related to the CGN Mar 17, 2021
@CrisTofani CrisTofani changed the title feat(Carta Giovani Nazionale): [#176959393,#177244360] Implements the screen to request and check for an OTP code related to the CGN feat(Carta Giovani Nazionale): [#176959393,#177244360] Implements the screen to request and copy for an OTP code related to the CGN Mar 17, 2021
@CrisTofani CrisTofani added the CGN label Mar 17, 2021
ts/features/bonus/cgn/components/otp/OtpNotWorking.tsx Outdated Show resolved Hide resolved
ts/features/bonus/cgn/screens/CgnOtpScreen.tsx Outdated Show resolved Hide resolved
ts/features/bonus/cgn/screens/CgnOtpScreen.tsx Outdated Show resolved Hide resolved
ts/features/bonus/cgn/screens/CgnOtpScreen.tsx Outdated Show resolved Hide resolved
ts/features/bonus/cgn/screens/CgnOtpScreen.tsx Outdated Show resolved Hide resolved
@CrisTofani CrisTofani requested a review from Undermaken March 18, 2021 11:06
@Undermaken Undermaken merged commit f7aa17a into master Mar 18, 2021
@Undermaken Undermaken deleted the 176959393-cgn-otp-screen branch March 18, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants