-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Carta Giovani Nazionale): [#176959393,#177244360] Implements the screen to request and copy for an OTP code related to the CGN #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
requested review from
debiff,
fabriziofff,
thisisjp and
Undermaken
as code owners
March 17, 2021 10:28
pagopa-github-bot
changed the title
[#176959393,#177244360] Implements the screen to ask and check for an OTP code related to the CGN
feat(Carta Giovani Nazionale): [#176959393,#177244360] Implements the screen to ask and check for an OTP code related to the CGN
Mar 17, 2021
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2908 +/- ##
==========================================
- Coverage 58.46% 52.84% -5.63%
==========================================
Files 883 819 -64
Lines 24272 22810 -1462
Branches 4470 4234 -236
==========================================
- Hits 14190 12053 -2137
- Misses 9990 10689 +699
+ Partials 92 68 -24
Continue to review full report at Codecov.
|
CrisTofani
changed the title
feat(Carta Giovani Nazionale): [#176959393,#177244360] Implements the screen to ask and check for an OTP code related to the CGN
feat(Carta Giovani Nazionale): [#176959393,#177244360] Implements the screen to request and check for an OTP code related to the CGN
Mar 17, 2021
CrisTofani
changed the title
feat(Carta Giovani Nazionale): [#176959393,#177244360] Implements the screen to request and check for an OTP code related to the CGN
feat(Carta Giovani Nazionale): [#176959393,#177244360] Implements the screen to request and copy for an OTP code related to the CGN
Mar 17, 2021
…76959393-cgn-otp-screen # Conflicts: # ts/features/bonus/cgn/screens/CgnDetailScreen.tsx
Undermaken
suggested changes
Mar 17, 2021
ts/features/bonus/bonusVacanze/components/buttons/ButtonConfigurations.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Matteo Boschi <[email protected]>
Undermaken
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the screen to show and copy the OTP code generated for the user CGN to get a discount by conventioned merchants
Registrazione.schermo.2021-03-17.alle.10.02.09.mov