Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#177144320,#177144482] Insert privative card number #2905

Merged
merged 13 commits into from
Mar 18, 2021

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Mar 16, 2021

Short description

This pr adds the screen that allows the user to enter their private card pan code.

Without focus With Focus
  • Min digit to enable the continue button: 1
  • Max digit: 19
  • Only number allowed

How to test

  • Add Payment method -> Add Supermarket card -> choose issuer
  • run ts/features/wallet/onboarding/privative/screens/__tests__/AddPrivativeCardNumberScreen.test.tsx

@pagopa-github-bot pagopa-github-bot changed the title [#177144320,#177144482] Insert privative card number feat(Bonus Pagamenti Digitali): [#177144320,#177144482] Insert privative card number Mar 16, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Mar 16, 2021

Affected stories

  • 🌟 #177144320: Come CIT, quando seleziono il marchio della mia carta privativa e questi è abilitato, voglio poter inserire il numero della mia carta ed effettuare la ricerca
  • 🌟 #177144482: Come CIT, quando sono nella schermata che mi consente di inserire il numero della mia carta privativa, voglio poter visualizzare l'informativa sul trattamento dei dati personali

Generated by 🚫 dangerJS against 5e5f070

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #2905 (5e5f070) into master (7315b64) will decrease coverage by 2.24%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2905      +/-   ##
==========================================
- Coverage   58.37%   56.13%   -2.25%     
==========================================
  Files         883      813      -70     
  Lines       24250    22184    -2066     
  Branches     4468     4153     -315     
==========================================
- Hits        14156    12453    -1703     
+ Misses      10002     9659     -343     
+ Partials       92       72      -20     
Impacted Files Coverage Δ
...privative/screens/AddPrivativeCardNumberScreen.tsx 61.70% <58.33%> (-4.97%) ⬇️
ts/components/LabelledItem.tsx 22.91% <0.00%> (-68.75%) ⬇️
...eens/details/transaction/BpdTransactionsScreen.tsx 37.83% <0.00%> (-62.17%) ⬇️
ts/utils/number.ts 38.46% <0.00%> (-61.54%) ⬇️
...rding/cobadge/screens/start/CoBadgeStartScreen.tsx 45.09% <0.00%> (-54.91%) ⬇️
ts/utils/appVersion.ts 36.66% <0.00%> (-53.34%) ⬇️
...oarding/cobadge/store/reducers/abiConfiguration.ts 48.00% <0.00%> (-52.00%) ⬇️
...ge/screens/search/SearchAvailableCoBadgeScreen.tsx 48.21% <0.00%> (-51.79%) ⬇️
ts/store/reducers/payments/history.ts 40.00% <0.00%> (-50.77%) ⬇️
...s/bonus/cgn/components/detail/CgnInfoboxDetail.tsx 52.00% <0.00%> (-48.00%) ⬇️
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7315b64...5e5f070. Read the comment docs.

@fabriziofff fabriziofff marked this pull request as ready for review March 16, 2021 19:45
…rivativeCardNumberScreen.test.tsx

Co-authored-by: Simone <[email protected]>
@fabriziofff fabriziofff requested a review from debiff March 18, 2021 09:12
@debiff debiff merged commit d52a9ae into master Mar 18, 2021
@debiff debiff deleted the 177144320-insert-privative-card-number branch March 18, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants