feat(Carta Giovani Nazionale): [#177058904] Introduces the Bottom Sheet that shows all the informations about an available discount for CGN #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
requested review from
debiff,
fabriziofff,
thisisjp and
Undermaken
as code owners
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2888 +/- ##
=======================================
Coverage 57.95% 57.95%
=======================================
Files 872 874 +2
Lines 23896 23954 +58
Branches 4418 4425 +7
=======================================
+ Hits 13849 13883 +34
- Misses 9958 9982 +24
Partials 89 89
Continue to review full report at Codecov.
|
…77059013-merchants-discount-item
…76959185-merchant-detail-screen # Conflicts: # ts/features/bonus/cgn/screens/merchants/CgnMerchantsListScreen.tsx
…b.com:pagopa/io-app into 177058904-discount-detail-bottom-sheet
Undermaken
suggested changes
Mar 12, 2021
ts/features/bonus/cgn/components/merchants/CgnDiscountDetail.tsx
Outdated
Show resolved
Hide resolved
ts/features/bonus/cgn/components/merchants/CgnDiscountDetail.tsx
Outdated
Show resolved
Hide resolved
ts/features/bonus/cgn/components/merchants/CgnDiscountDetail.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Matteo Boschi <[email protected]>
Undermaken
suggested changes
Mar 12, 2021
ts/features/bonus/cgn/components/merchants/CgnDiscountDetail.tsx
Outdated
Show resolved
Hide resolved
CrisTofani
commented
Mar 12, 2021
…detail-bottom-sheet' into 177058904-discount-detail-bottom-sheet
Undermaken
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #2886
Short description
This PR introduces the bottom sheet that displays all the information about a discount on a specific merchant.