Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Carta Giovani Nazionale): [#176959164,#177266269] Add analytics on cgn flow #2887

Merged
merged 8 commits into from
Mar 16, 2021

Conversation

ncannata-dev
Copy link
Contributor

Short description

Implementing analytics on CGN flow.

List of changes proposed in this pull request

First implementation of the analytics file that will trace the flows of the new CGN functionality.

How to test

Check on Mixpanel.

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Mar 10, 2021

Warnings
⚠️

Multiple stories with different types are associated with this Pull request.
Only one tag will be added, following the order: feature > bug > chore

Affected stories

  • 🌟 #176959164: Tracciare su Mixpanel gli eventi scatenati dai flussi di CGN
  • ⚙️ #177266269: Tracciare gli eventi di richiesta dell'OTP su Mixpanel

Generated by 🚫 dangerJS against f364f16

@pagopa-github-bot pagopa-github-bot changed the title [#176959164] Add analytics on cgn flow feat(Carta Giovani Nazionale): [#176959164] Add analytics on cgn flow Mar 10, 2021
@ncannata-dev ncannata-dev self-assigned this Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #2887 (f364f16) into master (0ac7d0c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2887   +/-   ##
=======================================
  Coverage   58.06%   58.06%           
=======================================
  Files         882      882           
  Lines       24213    24213           
  Branches     4465     4465           
=======================================
  Hits        14059    14059           
  Misses      10063    10063           
  Partials       91       91           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ac7d0c...f364f16. Read the comment docs.

Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the merge of #2882 we added some more actions to handle the generation of an OTP code related to the user's CGN, May we add these new actions to the analytics too?

@ncannata-dev ncannata-dev force-pushed the 176959164-add-cgn-analytics branch from ff1fa6a to 6f17de7 Compare March 12, 2021 15:04
@CrisTofani CrisTofani self-requested a review March 15, 2021 14:06
@ncannata-dev ncannata-dev changed the title feat(Carta Giovani Nazionale): [#176959164] Add analytics on cgn flow feat(Carta Giovani Nazionale): [#176959164#177266269] Add analytics on cgn flow Mar 16, 2021
@CrisTofani CrisTofani changed the title feat(Carta Giovani Nazionale): [#176959164#177266269] Add analytics on cgn flow feat(Carta Giovani Nazionale): [#176959164,#177266269] Add analytics on cgn flow Mar 16, 2021
@CrisTofani
Copy link
Contributor

@nicola-bitrocketdev Title was missing of a comma to separate the two story ids, now has been fixed 😉

When we're including multiple story ids the correct structure of the story title is:

[#PIVOTAL_ID1,#PIVOTAL_ID2] Some PR title

@ncannata-dev
Copy link
Contributor Author

ncannata-dev commented Mar 16, 2021

@nicola-bitrocketdev Title was missing of a comma to separate the two story ids, now has been fixed 😉

When we're including multiple story ids the correct structure of the story title is:

[#PIVOTAL_ID1,#PIVOTAL_ID2] Some PR title

my bad, sorry for typo 😅

Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicola-bitrocketdev PR lgtm but only creating the cgn action tracker is not enough to send actions to mixpanel.

We need to add the CGN tracker developed to the main analytics function, for reference see here

@CrisTofani CrisTofani merged commit a445fda into master Mar 16, 2021
@CrisTofani CrisTofani deleted the 176959164-add-cgn-analytics branch March 16, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants