-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Carta Giovani Nazionale): [#176959164,#177266269] Add analytics on cgn flow #2887
Conversation
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2887 +/- ##
=======================================
Coverage 58.06% 58.06%
=======================================
Files 882 882
Lines 24213 24213
Branches 4465 4465
=======================================
Hits 14059 14059
Misses 10063 10063
Partials 91 91 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the merge of #2882 we added some more actions to handle the generation of an OTP code related to the user's CGN, May we add these new actions to the analytics too?
ff1fa6a
to
6f17de7
Compare
@nicola-bitrocketdev Title was missing of a comma to separate the two story ids, now has been fixed 😉 When we're including multiple story ids the correct structure of the story title is:
|
my bad, sorry for typo 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicola-bitrocketdev PR lgtm but only creating the cgn action tracker is not enough to send actions to mixpanel.
We need to add the CGN tracker developed to the main analytics function, for reference see here
Short description
Implementing analytics on CGN flow.
List of changes proposed in this pull request
First implementation of the analytics file that will trace the flows of the new CGN functionality.
How to test
Check on Mixpanel.