feat(Bonus Pagamenti Digitali): [#177145461] Show privative cards in wallet home #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debiff
requested review from
CrisTofani,
fabriziofff and
Undermaken
as code owners
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2878 +/- ##
==========================================
+ Coverage 57.94% 58.00% +0.05%
==========================================
Files 877 880 +3
Lines 24065 24141 +76
Branches 4439 4453 +14
==========================================
+ Hits 13944 14002 +58
- Misses 10032 10049 +17
- Partials 89 90 +1
Continue to review full report at Codecov.
|
fabriziofff
suggested changes
Mar 10, 2021
| </Body> | ||
| } | ||
| right={renderRight(props, imgDimensions)} | ||
| onPress={() => props.navigateToCobadgeDetails(props.privative)} |
There was a problem hiding this comment.
Suggested change
| onPress={() => props.navigateToCobadgeDetails(props.privative)} | |
| onPress={() => props.navigateToPrivativeDetails(props.privative)} |
Comment on lines
83
to
85
| const mapDispatchToProps = (dispatch: Dispatch) => ({ | ||
| navigateToCobadgeDetails: (privative: PrivativePaymentMethod) => | ||
| dispatch(navigateToPrivativeDetailScreen(privative)) |
There was a problem hiding this comment.
Suggested change
| const mapDispatchToProps = (dispatch: Dispatch) => ({ | |
| navigateToCobadgeDetails: (privative: PrivativePaymentMethod) => | |
| dispatch(navigateToPrivativeDetailScreen(privative)) | |
| const mapDispatchToProps = (dispatch: Dispatch) => ({ | |
| navigateToPrivativeDetails: (privative: PrivativePaymentMethod) => | |
| dispatch(navigateToPrivativeDetailScreen(privative)) |
fabriziofff
suggested changes
Mar 10, 2021
ts/types/pagopa.ts
Outdated
| @@ -223,6 +225,10 @@ export type CreditCardPaymentMethod = RawCreditCardPaymentMethod & | |||
| PaymentMethodRepresentation & | |||
| WithAbi; | |||
|
|
|||
| export type PrivativePaymentMethod = CreditCardPaymentMethod & { | |||
There was a problem hiding this comment.
I was thinking about this and maybe the cleanest solution is to declare:
export type RawPrivativePaymentMethod = WalletV2WithoutInfo & {
kind: "Privative";
info: CardInfo;
};
export type PrivativePaymentMethod = RawPrivativePaymentMethod & { ... };In order to have a a specific type inside the domain model. What you think?
There was a problem hiding this comment.
LGTM, added in a62709b
Undermaken
suggested changes
Mar 12, 2021
ts/features/wallet/privative/component/PrivativeWalletPreview.tsx
Outdated
Show resolved
Hide resolved
ts/features/wallet/component/__test__/CardLayoutPreview.test.tsx
Outdated
Show resolved
Hide resolved
ts/features/wallet/privative/component/PrivativeWalletPreview.tsx
Outdated
Show resolved
Hide resolved
| expect(caption).not.toBeNull(); | ||
| expect(caption).toHaveTextContent(aPrivativeCard.caption); | ||
| }); | ||
| it("should show the fallback gdo logo if useImageResize return a size but there isn't the cardLogo", () => { |
There was a problem hiding this comment.
Suggested change
| it("should show the fallback gdo logo if useImageResize return a size but there isn't the cardLogo", () => { | |
| it("should show the fallback gdo logo if useImageResize returns a size but there isn't the cardLogo", () => { |
ts/features/wallet/privative/component/__tests__/PrivativeWalletPreview.test.tsx
Outdated
Show resolved
Hide resolved
Undermaken
approved these changes
Mar 12, 2021
…461-preview-privative-card
fabriziofff
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR show the preview of the privative cards in the wallet home.
List of changes proposed in this pull request
PrivativeWalletPreviewcomponentPrivativePaymentMethodtypeCardPreviewcomponent to favor composition