chore: [#176983007] Restore payment attempt saving #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w-3ds2' into 176983293-paywebview-3ds2
…76981421-payment-flow-3ds2 # Conflicts: # ts/components/wallet/PayWebViewModal.tsx
remove useless actions from analytics get payment psp from store instead from wallet
dispatch end web view distinguish from exit gracefully or by user
…low-3ds2' into 176981421-payment-flow-3ds2
Co-authored-by: Simone <[email protected]>
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2846 +/- ##
==========================================
- Coverage 57.04% 57.03% -0.01%
==========================================
Files 824 824
Lines 22866 22888 +22
Branches 4287 4295 +8
==========================================
+ Hits 13043 13055 +12
- Misses 9736 9746 +10
Partials 87 87
Continue to review full report at Codecov.
|
Undermaken
requested review from
CrisTofani,
debiff,
fabriziofff and
thisisjp
as code owners
Co-authored-by: Jacopo Pompilii <[email protected]>
Co-authored-by: Jacopo Pompilii <[email protected]>
…6-handle-payment-outcome
…983007-restore-payment-attempt-save
…983007-restore-payment-attempt-save
debiff
suggested changes
Feb 25, 2021
| @@ -109,7 +112,21 @@ class PaymentHistoryDetailsScreen extends React.Component<Props> { | |||
| color: paymentInfo.color, | |||
| description: paymentInfo.text11 | |||
| }; | |||
| const errorDetail = fromNullable(getErrorDescription(payment.failure)); | |||
| const errorDetail = fromNullable(getErrorDescription(payment.failure)).alt( | |||
There was a problem hiding this comment.
Can you add a comment here?
There was a problem hiding this comment.
Added within 192488f
debiff
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR restores the saving of a payment attempts.
With the new 3DS2 we have different signals to know if a payment ends successfully or not