chore(Bonus Pagamenti Digitali): [#176842973] Add tests for the CoBadge components #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debiff
requested review from
CrisTofani,
fabriziofff and
Undermaken
as code owners
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2826 +/- ##
==========================================
+ Coverage 57.21% 57.30% +0.09%
==========================================
Files 827 827
Lines 22997 22997
Branches 4308 4308
==========================================
+ Hits 13157 13179 +22
+ Misses 9752 9730 -22
Partials 88 88
Continue to review full report at Codecov.
|
fabriziofff
suggested changes
Feb 18, 2021
Comment on lines
70
to
89
| const ToBeTested: React.FunctionComponent<React.ComponentProps< | ||
| typeof CoBadgeChooseType | ||
| >> = (props: React.ComponentProps<typeof CoBadgeChooseType>) => ( | ||
| <CoBadgeChooseType {...props} /> | ||
| ); | ||
| const mockStore = configureMockStore<GlobalState>(); | ||
| const store: ReturnType<typeof mockStore> = mockStore({ | ||
| ...globalState | ||
| } as GlobalState); | ||
|
|
||
| return { | ||
| component: renderScreenFakeNavRedux<GlobalState, NavigationParams>( | ||
| ToBeTested, | ||
| ROUTES.WALLET_BPAY_DETAIL, | ||
| { abi, legacyAddCreditCardBack }, | ||
| store | ||
| ), | ||
| store | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const ToBeTested: React.FunctionComponent<React.ComponentProps< | |
| typeof CoBadgeChooseType | |
| >> = (props: React.ComponentProps<typeof CoBadgeChooseType>) => ( | |
| <CoBadgeChooseType {...props} /> | |
| ); | |
| const mockStore = configureMockStore<GlobalState>(); | |
| const store: ReturnType<typeof mockStore> = mockStore({ | |
| ...globalState | |
| } as GlobalState); | |
| return { | |
| component: renderScreenFakeNavRedux<GlobalState, NavigationParams>( | |
| ToBeTested, | |
| ROUTES.WALLET_BPAY_DETAIL, | |
| { abi, legacyAddCreditCardBack }, | |
| store | |
| ), | |
| store | |
| }; | |
| }; | |
| const mockStore = configureMockStore<GlobalState>(); | |
| const store: ReturnType<typeof mockStore> = mockStore({ | |
| ...globalState | |
| } as GlobalState); | |
| return { | |
| component: renderScreenFakeNavRedux<GlobalState, NavigationParams>( | |
| CoBadgeChooseType, | |
| ROUTES.WALLET_BPAY_DETAIL, | |
| { abi, legacyAddCreditCardBack }, | |
| store | |
| ), | |
| store | |
| }; | |
| }; |
What you think about avoid to wrap the component? Or there is some reason behind?
There was a problem hiding this comment.
You're right. There is no reason to wrap the component.
I initially wrapped it because I had some problems with the nav props, and this seemed to fix it.
Removed in 379f267
fabriziofff
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR add the tests missed during the development of the cobadge flow.
List of changes proposed in this pull request